From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.40]) by mx.groups.io with SMTP id smtpd.web12.661.1603906980700938206 for ; Wed, 28 Oct 2020 10:43:01 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=yFMcGqkJ; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.244.40, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiJoM1zM0f42yMw9CSCP1QWRpLoQGK1whQ+PaO/iRr1EHY763owG7fcQNBlwd3epI1JGkyTfZ+697h/cB4uBtlIon4Xy1Dcz4eASbvvrpRJDznmEYqldd6juJ1yrTZnIbzL9S9DfWasCwL5aEpvQZvujYw4/iN0UjM+LdJEOfB1gPLp/ilXZYKge959r7WMdHwwRXZX8Edpj7ERQlcI5OMSXVcfa0Nr4qARPeVBwHtcEatVIVINwv2YP8zw3HIq1BzYRmaoVf3ySXTX24lX8l2/rh/DogVjO5IwNSuzuhNsNKu/sPNY4rk3DEwhjS2ES5rSZvSub/sb163p7XeYxgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+sk/1/dyOCylOcwT6zD6Yz2Ch889r1yoUTLk03E9wUU=; b=iO5WMaYkWwUhKVeMyzMh0xr/tc7JZEI53wGsO1iQRywXIxbT/YHDD3/iR0l8QbgC26BOLxCYvrQZBJ2EJeVcoiolaqSoebI0ymc3J2ZMU93OZauRWciUKwfRx3vtWTXpjluj1CnlwAvo3KanhDGCg8h69FJMG5ZG3RnYZE0ADhDSSbjQQ4tIUE7dzQ7u/ZzEV9+zaJkJen0bDSIHYar5bz5kLP4CqYwN1y2joAAU04u2POOQx8y2cEj6GsYFXvZZ84KOZTEaIUGBV/mDk6309BVoJ92VC4bYhxklfelxVoNcJJ2ShpkY3dGKsHaCAJF2ny3RGxhuQkg3gN2bRuCIIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+sk/1/dyOCylOcwT6zD6Yz2Ch889r1yoUTLk03E9wUU=; b=yFMcGqkJ4u7le2Exmx2uK9Q2IeEPbpC33fwVQiVlSTP4YWIqBk4JhOG7b46Mj49eNZIE/QPqmEL1HfC88vPkHCTHv5gIdtMc+09semRN+buBaO3AhPJvewpq1+9IaVdebR7ifxgXFNDLhgsPqCIF2+sK3dKYs3Zkqjnh3soP5IU= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB2891.namprd12.prod.outlook.com (2603:10b6:5:188::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Wed, 28 Oct 2020 17:42:58 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba%6]) with mapi id 15.20.3499.027; Wed, 28 Oct 2020 17:42:58 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiDlm57lpI06IOWbnuWkjTogW1BBVENIIHYyIDAxLzExXSBNZGVQa2csIE92bWZQa2c6IENsZWFuIHVwIEdIQ0IgZmllbGQgb2Zmc2V0cyBhbmQgc2F2ZSBhcmVh?= To: "Dong, Eric" , "devel@edk2.groups.io" , gaoliming , "lersek@redhat.com" , "Ni, Ray" , "Kinney, Michael D" CC: 'Brijesh Singh' , "Liu, Zhiguang" , "Justen, Jordan L" , 'Ard Biesheuvel' References: <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com> <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn> <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com> <006f01d6a67d$80b77d80$82267880$@byosoft.com.cn> <8734b948-e36c-81f4-43ae-6c63fba1374b@amd.com> <004401d6a744$b6208e90$2261abb0$@byosoft.com.cn> <008b01d6a812$4a331df0$de9959d0$@byosoft.com.cn> <4f1962a2-f417-4c27-1ddb-957b3d3abeb0@redhat.com> <000401d6a8e8$4b15d790$e14186b0$@byosoft.com.cn> <7a298343-a73d-ac5a-af90-a58ad9e97937@amd.com> From: "Lendacky, Thomas" Message-ID: <3c23f8c5-450b-321e-7a9c-c6754ab6900c@amd.com> Date: Wed, 28 Oct 2020 12:42:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0701CA0029.namprd07.prod.outlook.com (2603:10b6:803:2d::14) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.118] (165.204.77.1) by SN4PR0701CA0029.namprd07.prod.outlook.com (2603:10b6:803:2d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Wed, 28 Oct 2020 17:42:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b1bb8953-ebf7-4d8e-e213-08d87b68e8b4 X-MS-TrafficTypeDiagnostic: DM6PR12MB2891: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GYMxwLxtH1gM9ze010ThTUSqNXfheRJDHZZKj98Nu4NQiJHQkV3lJvcNVwNP8HY69YYljKhsxi4LLy5LD/7xcz7Q2rvVNteboRvYfTSosJerjYXfSs3NNMZUUsDudM6kK1G6tJuLS12W841MaXYEGQZnTrC7et9cxmasbUH43bxaa3yHY0DZtUSCJUPopfeX6fwSqX/0bgcE4ENkERDvG4iZSymn4vv3EA6bW4+SCKeZh5Dw9l1o7ID8Uz+zHJgVUOsm3CllvTPi9VUemRgWnpBriEDxCMz2RI3NHmc0J5L+jO7iDZcD8qHmLRGuh9hCKaGU9htI1UtjjoVu9bu2mykcvCjJVbkLYg2WfnpY6dMCgbclmLCAXa1/ihFxXIPIAUEGGXdj9wosQ8RL1MYq/HU2+7uP2tM3TopTvm82M/nMZzbz+SbDG4wnRrwD5F1n2qA+UI019orgIIlZoZOIDw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(346002)(366004)(39860400002)(45080400002)(16526019)(6486002)(110136005)(52116002)(224303003)(54906003)(966005)(186003)(478600001)(31696002)(53546011)(26005)(2616005)(16576012)(31686004)(316002)(86362001)(2906002)(8936002)(36756003)(66476007)(4326008)(83380400001)(5660300002)(956004)(66946007)(66556008)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 0wk2dO8NI5Inw7S9I3ND3fwhrcJVZC53fhB/DjxNI47PaG3BYxBcXzA1T8RnHthM9RVSR/Qwf/1+cHpofq34wyIVFFSYv6UfPG6yvA2kmyMJ2YLfNrHOuev7iJZOOafAQw5inMJ/UlK55GoRhj2hOdh6gqgQ038BZ9olWryf7RXQfSkpkZ4dIGVPiJ2iZRQrMrZcFG4LhsHtVhQYcs48CSvFjYS3D5cZSj5K8WgQdcaktwYCPYwIIvYOMR8Tf+awFN4D5s7cENwcN+hodCcJcYodF6BwosRPnKfkGCQiT7vkI0Kcn0MUkIxxOQYL5hhzQmU0aYjwWK1sWuS5VXXOK5pD0OsQ2j9RBlpx5tONnpQtZ+4CCm6IgtxeW8nuWwke6gq7qJsbmQgL6G6KNmZZMLSwcCNUL0JorUbhVJHc7nCTyZM+LicoWTD0qEWvhIQ+ZLXuKBiH2IYXMUoiOC8NR6cJx8tG9SWBraBCh+NbkyrnH/pPwZ0bK1XZyAmC7fGOa3Mud7oIhmgDH39DFVLJAxkruO7fgo51dTAZejt//gE5vUQu4FLUfi6zA9pge/DL9gEXi9OrRYnzZFTJhoVGGh0AG0mrqJmBVOabn6++ZlgzJSmeBeaKsFi0Fo4HzK9mBcePHiG4kjWh8NZLx9sPlg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1bb8953-ebf7-4d8e-e213-08d87b68e8b4 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2020 17:42:58.6207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IT0Pi4/O77YiiI6jkgE7E0jsnsSZ1B6UIV+uyQ77M7tdj+sQoFdw1TWpz0S7bopr6zyJQ2JRlHYat7aaRSNzXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2891 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/27/20 2:57 AM, Dong, Eric wrote: > I agree with Laszlo, we need to care Bisectability first. Thanks for responding, Eric. I'll submit v3 as previously submitted. Thanks, Tom >=20 > Thanks, > Eric > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Lendacky,= Thomas > Sent: Tuesday, October 27, 2020 12:34 AM > To: gaoliming ; devel@edk2.groups.io; lersek@r= edhat.com; Ni, Ray ; Dong, Eric ; Ki= nney, Michael D > Cc: 'Brijesh Singh' ; Liu, Zhiguang ; Justen, Jordan L ; 'Ard Biesheuvel'= > Subject: Re: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B= = =9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [PATCH v2 01/11] Mde= Pkg, OvmfPkg: Clean up GHCB field offsets and save area >=20 > On 10/22/20 9:57 PM, gaoliming wrote: >> Laszlo: >> I agree Bisectability is important. I want to consider the impact and = balance the change. Now, this change will update UefiCpuPkg. I also want to= collect the feedback from UefiCpuPkg maintainer: Ray and Eric.=20 >=20 > Ray/Eric, >=20 > Any feedback on this question (specifically for patch #10 of this series= , not this patch)? I'd also prefer to maintain bisectability and therefore = submit the changes to the UefiCpuPkg and OvmfPkg in the same patch. >=20 > Thanks, > Tom >=20 >> >> Thanks >> Liming >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66536+4905953+8761045@groups= .io >>> =E4=BB=A3=E8=A1=A8 Lasz= lo Ersek >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B410=E6=9C=8822=E6=97= = =A5 21:13 >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; dev= el@edk2.groups.io;=20 >>> thomas.lendacky@amd.com >>> =E6=8A=84=E9=80=81: 'Brijesh Singh' ; 'Michael = D Kinney' >>> ; 'Zhiguang Liu'=20 >>> ; 'Jordan Justen' ;= 'Ard Biesheuvel' >>> >>> =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5= =A4=8D: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [PATCH v2 01/11] MdePkg, >>> OvmfPkg: Clean up GHCB field offsets and save area >>> >>> On 10/22/20 03:25, gaoliming wrote: >>>> Tom: >>>> For the patch in UefiCpuPkg, this changes the library interface.=20 >>>> So, the >>> consumer and producer code is required to be changed together. There= =20 >>> is no good compatible way to do it. I still prefer to separate them=20 >>> for the different package. Although the first commit breaks the tree,= =20 >>> your patch is the patch serial, they will be merged together. Its impa= ct should be small. >>> >>> I really disagree here. Bisectability is way more important, in my=20 >>> opinion, than avoiding a multi-package patch. >>> >>> I agree we should avoid multi-package patches as much as we can --=20 >>> but not more than we can. Bisectability (=3D keeping the tree buildabl= e=20 >>> at every commit) is very important, in my opinion. >>> >>> Thanks, >>> Laszlo >>> >>> >>> >>> >>> >> >> >> >=20 >=20 >=20 >=20 >=20