From: "Ma, Hua" <hua.ma@intel.com>
To: <devel@edk2.groups.io>, Gua Guo <gua.guo@intel.com>,
Guo Dong <guo.dong@intel.com>, James Lu <james.lu@intel.com>,
Sean Rhodes <sean@starlabs.systems>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer
Date: Fri, 5 Jan 2024 14:19:12 +0800 [thread overview]
Message-ID: <3c2e3cd4-a891-e32f-7488-87762c69502a@intel.com> (raw)
In-Reply-To: <17A75CEA85AC7172.16812@groups.io>
Add maintainers to help review the patch,
thank you,
Ma Hua
On 1/5/2024 1:38 PM, Ma, Hua wrote:
> Add macro to enable selection of timer
>
> - HPET: UEFI Payload will use HPET timer
> - LAPIC: UEFI Payload will use local APIC timer
>
> Signed-off-by: Hua Ma <hua.ma@intel.com>
> ---
> UefiPayloadPkg/UefiPayloadPkg.dsc | 16 ++++++++++++++++
> UefiPayloadPkg/UefiPayloadPkg.fdf | 4 ++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index b8b13ad201..4f195c1e52 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -139,6 +139,12 @@
> # Note: for emulation platform such as QEMU, this may not work and should set it as FALSE
> DEFINE CPU_TIMER_LIB_ENABLE = TRUE
>
> + #
> + # HPET: UEFI Payload will use HPET timer
> + # LAPIC: UEFI Payload will use local APIC timer
> + #
> + DEFINE TIMER_SUPPORT = HPET
> +
> DEFINE MULTIPLE_DEBUG_PORT_SUPPORT = FALSE
>
> [BuildOptions]
> @@ -676,7 +682,17 @@
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
>
>
> +!if $(TIMER_SUPPORT) == "HPET"
> PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
> +!elseif $(TIMER_SUPPORT) == "LAPIC"
> + OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf {
> + <LibraryClasses>
> + NestedInterruptTplLib|OvmfPkg/Library/NestedInterruptTplLib/NestedInterruptTplLib.inf
> + }
> +!else
> + !error "Invalid TIMER_SUPPORT"
> +!endif
> +
> MdeModulePkg/Universal/Metronome/Metronome.inf
> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
> MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index 835798be1c..7d04a8cffd 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -161,7 +161,11 @@ INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> !endif
> INF UefiCpuPkg/CpuDxe/CpuDxe.inf
>
> +!if $(TIMER_SUPPORT) == "HPET"
> INF PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
> +!elseif $(TIMER_SUPPORT) == "LAPIC"
> +INF OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf
> +!endif
> INF MdeModulePkg/Universal/Metronome/Metronome.inf
> INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
> INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113220): https://edk2.groups.io/g/devel/message/113220
Mute This Topic: https://groups.io/mt/103538255/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next parent reply other threads:[~2024-01-05 6:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <17A75CEA85AC7172.16812@groups.io>
2024-01-05 6:19 ` Ma, Hua [this message]
2024-01-05 8:20 ` [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer Guo, Gua
2024-01-05 5:38 Ma, Hua
2024-01-09 23:48 ` Benjamin Doron
2024-01-10 1:28 ` Nate DeSimone
2024-01-10 2:09 ` Benjamin Doron
2024-01-10 1:27 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2e3cd4-a891-e32f-7488-87762c69502a@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox