From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D011121A0290B for ; Thu, 25 May 2017 12:58:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23DCF15552; Thu, 25 May 2017 19:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 23DCF15552 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 23DCF15552 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-147.phx2.redhat.com [10.3.116.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7ADA1756BF; Thu, 25 May 2017 19:58:19 +0000 (UTC) To: Jordan Justen , Brijesh Singh Cc: "Ni, Ruiyu" , Thomas.Lendacky@amd.com, edk2-devel@lists.01.org, leo.duran@amd.com, Jiewen Yao References: <1495466592-21641-1-git-send-email-brijesh.singh@amd.com> <1495466592-21641-8-git-send-email-brijesh.singh@amd.com> <149573856411.17919.1913237471235271079@jljusten-skl.jf.intel.com> From: Laszlo Ersek Message-ID: <3c45a02e-f41b-a441-0a85-09f0e402185f@redhat.com> Date: Thu, 25 May 2017 21:58:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <149573856411.17919.1913237471235271079@jljusten-skl.jf.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 May 2017 19:58:21 +0000 (UTC) Subject: Re: [PATCH v5 07/14] OvmfPkg:IoMmuDxe: Add IoMmuDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 19:58:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/25/17 20:56, Jordan Justen wrote: > On 2017-05-25 10:58:45, Laszlo Ersek wrote: >> >> If you add a patch to the series where you change the DEPEX of >> PciHostBridgeDxe to >> >> gEdkiiIoMmuProtocolGuid OR gEdkiiIoMmuAbsentProtocolGuid >> >> then the maintainer (Ray or Jiewen I think) will likely reject that >> patch, because afterwards, all platforms that include PciHostBridgeDxe >> would suddenly have to produce gEdkiiIoMmuAbsentProtocolGuid, minimally. > > I haven't worked with it, but it does appear that feature PCD's can be > used to conditionally add new depex values. > > $ git grep -e '|.*Pcd' -- '*.inf' I've now reviewed the result list for this search, and none of the results are contained in a [Depex] section actually. They are all under [Protocols], [Guids], or [Pcd] -- there doesn't seem to be an example for a FeaturePCD-dependent DEPEX. > I'm not sure if that feature works with depex 'OR'. > > Regarding IoMmuAbsent or IoMmuDetectionAttempted, they seem similar. Right, I'm fine with either. Thanks, Laszlo