From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 02 Jul 2019 08:20:25 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F55CC0495A1; Tue, 2 Jul 2019 15:20:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-172.ams2.redhat.com [10.36.117.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id B89507DF62; Tue, 2 Jul 2019 15:20:13 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports From: "Laszlo Ersek" To: devel@edk2.groups.io, ray.ni@intel.com Cc: "Dong, Eric" References: <20190628064700.549472-1-ray.ni@intel.com> <20190628064700.549472-4-ray.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C211134@SHSMSX104.ccr.corp.intel.com> <1a147a74-9986-1287-5334-5876eebe7682@redhat.com> Message-ID: <3c51b8a8-7517-6377-51c8-9e33c0c2af2d@redhat.com> Date: Tue, 2 Jul 2019 17:20:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1a147a74-9986-1287-5334-5876eebe7682@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 02 Jul 2019 15:20:20 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/02/19 17:18, Laszlo Ersek wrote: > On 07/02/19 16:44, Ni, Ray wrote: >> Laszlo, >> I agree with your changes. >> Will include your changes in V2. > > Thanks, Ray -- currently waiting for suitable hardware (with 5-level > paging support) to become available internally @RH for my testing. > > On host hardware that does not support 5-level paging, there seem to be > no adverse effects. > > Regression-tested-by: Laszlo Ersek Forgot to mention that this applies with the PatchInstructionX86() update in place. Thanks Laszlo