Re: [edk2-devel] [PATCH V2 1/2] MdeModulePkg PeiCore: Fix typos

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote:
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>   MdeModulePkg/Core/Pei/PeiMain.inf             | 10 ++--
>   MdeModulePkg/Core/Pei/FwVol/FwVol.h           | 20 ++++----
>   MdeModulePkg/Core/Pei/PeiMain.h               | 40 ++++++++--------
>   MdeModulePkg/Core/Pei/Dependency/Dependency.c |  8 ++--
>   MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 48 +++++++++----------
>   MdeModulePkg/Core/Pei/FwVol/FwVol.c           | 50 ++++++++++----------
>   MdeModulePkg/Core/Pei/Hob/Hob.c               |  4 +-
>   MdeModulePkg/Core/Pei/Image/Image.c           | 10 ++--
>   MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 16 +++----
>   MdeModulePkg/Core/Pei/PeiMain/PeiMain.c       |  2 +-
>   MdeModulePkg/Core/Pei/Ppi/Ppi.c               |  4 +-
>   MdeModulePkg/Core/Pei/Security/Security.c     | 12 ++---
>   12 files changed, 112 insertions(+), 112 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/PeiMain.inf b/MdeModulePkg/Core/Pei/PeiMain.inf
> index 7c482dacfc..6e25cc4023 100644
> --- a/MdeModulePkg/Core/Pei/PeiMain.inf
> +++ b/MdeModulePkg/Core/Pei/PeiMain.inf
> @@ -69,12 +69,12 @@
>   
>   [Guids]
>     gPeiAprioriFileNameGuid       ## SOMETIMES_CONSUMES   ## File
> -  ## PRODUCES   ## UNDEFINED # Install ppi
> -  ## CONSUMES   ## UNDEFINED # Locate ppi
> +  ## PRODUCES   ## UNDEFINED # Install PPI
> +  ## CONSUMES   ## UNDEFINED # Locate PPI
>     gEfiFirmwareFileSystem2Guid
> -  ## PRODUCES   ## UNDEFINED # Install ppi
> -  ## CONSUMES   ## UNDEFINED # Locate ppi
> -  ## CONSUMES   ## GUID      # Used to compare with FV's file system guid and get the FV's file system format
> +  ## PRODUCES   ## UNDEFINED # Install PPI
> +  ## CONSUMES   ## UNDEFINED # Locate PPI
> +  ## CONSUMES   ## GUID      # Used to compare with FV's file system GUID and get the FV's file system format
>     gEfiFirmwareFileSystem3Guid
>   
>   [Ppis]
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.h b/MdeModulePkg/Core/Pei/FwVol/FwVol.h
> index ca80e84e0f..263f0d7a56 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.h
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.h
> @@ -1,7 +1,7 @@
>   /** @file
>     The internal header file for firmware volume related definitions.
>   
> -Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
>   SPDX-License-Identifier: BSD-2-Clause-Patent
>   
>   **/
> @@ -303,12 +303,12 @@ FindFileEx (
>     );
>   
>   /**
> -  Report the information for a new discoveried FV in unknown format.
> +  Report the information for a new discovered FV in unknown format.
>   
> -  If the EFI_PEI_FIRMWARE_VOLUME_PPI has not been installed for specifical FV format, but
> -  the FV in this FV format has been discoveried, then the information of this FV
> +  If the EFI_PEI_FIRMWARE_VOLUME_PPI has not been installed for specific FV format, but
> +  the FV in this FV format has been discovered, then the information of this FV
>     will be cached into PEI_CORE_INSTANCE's UnknownFvInfo array.
> -  Also a notification would be installed for unknown FV format guid, if EFI_PEI_FIRMWARE_VOLUME_PPI
> +  Also a notification would be installed for unknown FV format GUID, if EFI_PEI_FIRMWARE_VOLUME_PPI
>     is installed later by platform's PEIM, the original unknown FV will be processed by
>     using new installed EFI_PEI_FIRMWARE_VOLUME_PPI.
>   
> @@ -325,14 +325,14 @@ AddUnknownFormatFvInfo (
>     );
>   
>   /**
> -  Find the FV information according to FV format guid.
> +  Find the FV information according to FV format GUID.
>   
> -  This routine also will remove the FV information found by given FV format guid from
> +  This routine also will remove the FV information found by given FV format GUID from
>     PrivateData->UnknownFvInfo[].
>   
>     @param PrivateData      Point to instance of PEI_CORE_INSTANCE
> -  @param Format           Point to given FV format guid
> -  @param FvInfo           On return, the pointer of FV information buffer in given FV format guid
> +  @param Format           Point to given FV format GUID
> +  @param FvInfo           On return, the pointer of FV information buffer in given FV format GUID
>     @param FvInfoSize       On return, the size of FV information buffer.
>     @param AuthenticationStatus On return, the authentication status of FV information buffer.
>   
> @@ -352,7 +352,7 @@ FindUnknownFormatFvInfo (
>     Notification callback function for EFI_PEI_FIRMWARE_VOLUME_PPI.
>   
>     When a EFI_PEI_FIRMWARE_VOLUME_PPI is installed to support new FV format, this
> -  routine is called to process all discoveried FVs in this format.
> +  routine is called to process all discovered FVs in this format.
>   
>     @param PeiServices       An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation
>     @param NotifyDescriptor  Address of the notification descriptor data structure.
> diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
> index f2aa97c664..3f61247a0f 100644
> --- a/MdeModulePkg/Core/Pei/PeiMain.h
> +++ b/MdeModulePkg/Core/Pei/PeiMain.h
> @@ -47,7 +47,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>   
>   ///
>   /// It is an FFS type extension used for PeiFindFileEx. It indicates current
> -/// Ffs searching is for all PEIMs can be dispatched by PeiCore.
> +/// FFS searching is for all PEIMs can be dispatched by PeiCore.
>   ///
>   #define PEI_CORE_INTERNAL_FFS_FILE_DISPATCH_TYPE   0xff
>   
> @@ -116,7 +116,7 @@ typedef struct {
>   } PEI_PPI_DATABASE;
>   
>   //
> -// PEI_CORE_FV_HANDE.PeimState
> +// PEI_CORE_FV_HANDLE.PeimState
>   // Do not change these values as there is code doing math to change states.
>   // Look for Private->Fv[FvCount].PeimState[PeimCount]++;
>   //
> @@ -136,11 +136,11 @@ typedef struct {
>     EFI_PEI_FV_HANDLE                   FvHandle;
>     UINTN                               PeimCount;
>     //
> -  // Ponter to the buffer with the PeimCount number of Entries.
> +  // Pointer to the buffer with the PeimCount number of Entries.
>     //
>     UINT8                               *PeimState;
>     //
> -  // Ponter to the buffer with the PeimCount number of Entries.
> +  // Pointer to the buffer with the PeimCount number of Entries.
>     //
>     EFI_PEI_FILE_HANDLE                 *FvFileHandles;
>     BOOLEAN                             ScanFv;
> @@ -277,7 +277,7 @@ struct _PEI_CORE_INSTANCE {
>     //
>     // For Loading modules at fixed address feature to cache the top address below which the
>     // Runtime code, boot time code and PEI memory will be placed. Please note that the offset between this field
> -  // and  Ps should not be changed since maybe user could get this top address by using the offet to Ps.
> +  // and Ps should not be changed since maybe user could get this top address by using the offset to Ps.
>     //
>     EFI_PHYSICAL_ADDRESS               LoadModuleAtFixAddressTopAddress;
>     //
> @@ -372,7 +372,7 @@ PeiCore (
>   
>     This is the POSTFIX version of the dependency evaluator.  When a
>     PUSH [PPI GUID] is encountered, a pointer to the GUID is stored on
> -  the evaluation stack.  When that entry is poped from the evaluation
> +  the evaluation stack.  When that entry is popped from the evaluation

Should we also fix POPed -> POPped?

Regardless:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>     stack, the PPI is checked if it is installed.  This method allows
>     some time savings as not all PPIs must be checked for certain
>     operation types (AND, OR).
[...]