From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.6028.1574946169995134234 for ; Thu, 28 Nov 2019 05:02:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P/HUstrU; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574946169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=orZhhJQuM8XT8rarLeDA0hvTkmKCj6BjmsD4Ii4qzKo=; b=P/HUstrUcqRMOWJhiHEcWWBNfBbWP0D5QApRASL45ni+j+I4mQncApkWs5fvF4hnjfehyP b8MUFpsgHxNZKjf32h0h4jFB6FCmtafD6UgFULyUQS/tQs03p6BrZa04S/x5lXnCqFLFk6 E2yM9UdqR9Tcs63xkEqW39wBxjmGJLA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-cE1lPSarO66Q8H6wOHd6mg-1; Thu, 28 Nov 2019 08:02:47 -0500 Received: by mail-wr1-f72.google.com with SMTP id l20so3996676wrc.13 for ; Thu, 28 Nov 2019 05:02:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=orZhhJQuM8XT8rarLeDA0hvTkmKCj6BjmsD4Ii4qzKo=; b=mailFxyq5T5VytuIRgEJ2TR+Qx9rR1UaLL+BVFG3jWlvvsM6BqeF9TGWTZTJ5tJsYS sTJvV2LapNfz7bkrqeTaNvobYZ/g+PTJuG0GWPcieAgg2ikVWu0Wszb99bl273LzKSma LEhFukvnBRNZG9Vx7/YvIldHN5O1qXwasCTvt6uuN4o8ABB2O/gL+Vyz59a/hQxSySGL ME/1ds8/HmgwsKs2eQuZ2JXK7WBGcmriXb/r9BGyMCwnkOte5YSKI4fi2oqsD4Js41ol 1nHaHw2e/V2oe2py31Xna6t7wL7k6ptpTFfkZFaoEEZfvf1iCennqTi14oxkwFNMhlix ZPDA== X-Gm-Message-State: APjAAAXcHlWsV1Zq4MpUzBGtRq96rnDw6HZ/ORZPi8MO2e9d2agPL/Py 67eGaH9p98sAtaWLgbAFcaPcMp8BsnLnzv6uzzfv0+z/vWO+HZAU4Tj18+vn5367rC8UhyaNRou lFRAcVvVzfpO+VQ== X-Received: by 2002:a7b:c3ce:: with SMTP id t14mr9097608wmj.22.1574946166010; Thu, 28 Nov 2019 05:02:46 -0800 (PST) X-Google-Smtp-Source: APXvYqz4Q4YnYZ/nHOQk0IAk7PpI9+QnUrPXTENO2MZjlq0d9/hz+vNfySpNdIQRiexjm8j36BsR4w== X-Received: by 2002:a7b:c3ce:: with SMTP id t14mr9097581wmj.22.1574946165735; Thu, 28 Nov 2019 05:02:45 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id 11sm11009688wmb.34.2019.11.28.05.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2019 05:02:45 -0800 (PST) Subject: Re: [edk2-devel] [PATCH V2 1/2] MdeModulePkg PeiCore: Fix typos To: devel@edk2.groups.io, michael.a.kubacki@intel.com Cc: Dandan Bi , Liming Gao , Jian J Wang , Hao A Wu References: <20191127195747.3192-1-michael.a.kubacki@intel.com> <20191127195747.3192-2-michael.a.kubacki@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <3c758e02-fb4d-95e8-9d83-cef3902e346d@redhat.com> Date: Thu, 28 Nov 2019 14:02:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191127195747.3192-2-michael.a.kubacki@intel.com> X-MC-Unique: cE1lPSarO66Q8H6wOHd6mg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 11/27/19 8:57 PM, Kubacki, Michael A via Groups.Io wrote: > Cc: Dandan Bi > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Core/Pei/PeiMain.inf | 10 ++-- > MdeModulePkg/Core/Pei/FwVol/FwVol.h | 20 ++++---- > MdeModulePkg/Core/Pei/PeiMain.h | 40 ++++++++-------- > MdeModulePkg/Core/Pei/Dependency/Dependency.c | 8 ++-- > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 48 +++++++++---------- > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 50 ++++++++++---------- > MdeModulePkg/Core/Pei/Hob/Hob.c | 4 +- > MdeModulePkg/Core/Pei/Image/Image.c | 10 ++-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 16 +++---- > MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 2 +- > MdeModulePkg/Core/Pei/Ppi/Ppi.c | 4 +- > MdeModulePkg/Core/Pei/Security/Security.c | 12 ++--- > 12 files changed, 112 insertions(+), 112 deletions(-) > > diff --git a/MdeModulePkg/Core/Pei/PeiMain.inf b/MdeModulePkg/Core/Pei/PeiMain.inf > index 7c482dacfc..6e25cc4023 100644 > --- a/MdeModulePkg/Core/Pei/PeiMain.inf > +++ b/MdeModulePkg/Core/Pei/PeiMain.inf > @@ -69,12 +69,12 @@ > > [Guids] > gPeiAprioriFileNameGuid ## SOMETIMES_CONSUMES ## File > - ## PRODUCES ## UNDEFINED # Install ppi > - ## CONSUMES ## UNDEFINED # Locate ppi > + ## PRODUCES ## UNDEFINED # Install PPI > + ## CONSUMES ## UNDEFINED # Locate PPI > gEfiFirmwareFileSystem2Guid > - ## PRODUCES ## UNDEFINED # Install ppi > - ## CONSUMES ## UNDEFINED # Locate ppi > - ## CONSUMES ## GUID # Used to compare with FV's file system guid and get the FV's file system format > + ## PRODUCES ## UNDEFINED # Install PPI > + ## CONSUMES ## UNDEFINED # Locate PPI > + ## CONSUMES ## GUID # Used to compare with FV's file system GUID and get the FV's file system format > gEfiFirmwareFileSystem3Guid > > [Ppis] > diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.h b/MdeModulePkg/Core/Pei/FwVol/FwVol.h > index ca80e84e0f..263f0d7a56 100644 > --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.h > +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.h > @@ -1,7 +1,7 @@ > /** @file > The internal header file for firmware volume related definitions. > > -Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -303,12 +303,12 @@ FindFileEx ( > ); > > /** > - Report the information for a new discoveried FV in unknown format. > + Report the information for a new discovered FV in unknown format. > > - If the EFI_PEI_FIRMWARE_VOLUME_PPI has not been installed for specifical FV format, but > - the FV in this FV format has been discoveried, then the information of this FV > + If the EFI_PEI_FIRMWARE_VOLUME_PPI has not been installed for specific FV format, but > + the FV in this FV format has been discovered, then the information of this FV > will be cached into PEI_CORE_INSTANCE's UnknownFvInfo array. > - Also a notification would be installed for unknown FV format guid, if EFI_PEI_FIRMWARE_VOLUME_PPI > + Also a notification would be installed for unknown FV format GUID, if EFI_PEI_FIRMWARE_VOLUME_PPI > is installed later by platform's PEIM, the original unknown FV will be processed by > using new installed EFI_PEI_FIRMWARE_VOLUME_PPI. > > @@ -325,14 +325,14 @@ AddUnknownFormatFvInfo ( > ); > > /** > - Find the FV information according to FV format guid. > + Find the FV information according to FV format GUID. > > - This routine also will remove the FV information found by given FV format guid from > + This routine also will remove the FV information found by given FV format GUID from > PrivateData->UnknownFvInfo[]. > > @param PrivateData Point to instance of PEI_CORE_INSTANCE > - @param Format Point to given FV format guid > - @param FvInfo On return, the pointer of FV information buffer in given FV format guid > + @param Format Point to given FV format GUID > + @param FvInfo On return, the pointer of FV information buffer in given FV format GUID > @param FvInfoSize On return, the size of FV information buffer. > @param AuthenticationStatus On return, the authentication status of FV information buffer. > > @@ -352,7 +352,7 @@ FindUnknownFormatFvInfo ( > Notification callback function for EFI_PEI_FIRMWARE_VOLUME_PPI. > > When a EFI_PEI_FIRMWARE_VOLUME_PPI is installed to support new FV format, this > - routine is called to process all discoveried FVs in this format. > + routine is called to process all discovered FVs in this format. > > @param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation > @param NotifyDescriptor Address of the notification descriptor data structure. > diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h > index f2aa97c664..3f61247a0f 100644 > --- a/MdeModulePkg/Core/Pei/PeiMain.h > +++ b/MdeModulePkg/Core/Pei/PeiMain.h > @@ -47,7 +47,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > /// > /// It is an FFS type extension used for PeiFindFileEx. It indicates current > -/// Ffs searching is for all PEIMs can be dispatched by PeiCore. > +/// FFS searching is for all PEIMs can be dispatched by PeiCore. > /// > #define PEI_CORE_INTERNAL_FFS_FILE_DISPATCH_TYPE 0xff > > @@ -116,7 +116,7 @@ typedef struct { > } PEI_PPI_DATABASE; > > // > -// PEI_CORE_FV_HANDE.PeimState > +// PEI_CORE_FV_HANDLE.PeimState > // Do not change these values as there is code doing math to change states. > // Look for Private->Fv[FvCount].PeimState[PeimCount]++; > // > @@ -136,11 +136,11 @@ typedef struct { > EFI_PEI_FV_HANDLE FvHandle; > UINTN PeimCount; > // > - // Ponter to the buffer with the PeimCount number of Entries. > + // Pointer to the buffer with the PeimCount number of Entries. > // > UINT8 *PeimState; > // > - // Ponter to the buffer with the PeimCount number of Entries. > + // Pointer to the buffer with the PeimCount number of Entries. > // > EFI_PEI_FILE_HANDLE *FvFileHandles; > BOOLEAN ScanFv; > @@ -277,7 +277,7 @@ struct _PEI_CORE_INSTANCE { > // > // For Loading modules at fixed address feature to cache the top address below which the > // Runtime code, boot time code and PEI memory will be placed. Please note that the offset between this field > - // and Ps should not be changed since maybe user could get this top address by using the offet to Ps. > + // and Ps should not be changed since maybe user could get this top address by using the offset to Ps. > // > EFI_PHYSICAL_ADDRESS LoadModuleAtFixAddressTopAddress; > // > @@ -372,7 +372,7 @@ PeiCore ( > > This is the POSTFIX version of the dependency evaluator. When a > PUSH [PPI GUID] is encountered, a pointer to the GUID is stored on > - the evaluation stack. When that entry is poped from the evaluation > + the evaluation stack. When that entry is popped from the evaluation Should we also fix POPed -> POPped? Regardless: Reviewed-by: Philippe Mathieu-Daude > stack, the PPI is checked if it is installed. This method allows > some time savings as not all PPIs must be checked for certain > operation types (AND, OR). [...]