Re: [PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName dereference

[Rebecca Cran <rebecca@nuviainc.com>]

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

It looks like this hasn't been committed yet - I still get a crash when 
running acpiview on my Overdrive 1000 system, and see the original code 
is still on the latest master.

Could someone commit it please?


-- 
Rebecca Cran


On 12/14/21 09:08, Sami Mujawar wrote:
>
> Hi Chris,
>
> Thanks for fixing this issue.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> *From: *Chris Jones <christopher.jones@arm.com>
> *Date: *Tuesday, 14 December 2021 at 12:38
> *To: *devel@edk2.groups.io <devel@edk2.groups.io>
> *Cc: *ray.ni@intel.com <ray.ni@intel.com>, zhichao.gao@intel.com 
> <zhichao.gao@intel.com>, rebecca@nuviainc.com <rebecca@nuviainc.com>, 
> Sami Mujawar <Sami.Mujawar@arm.com>, nd <nd@arm.com>
> *Subject: *[PATCH v1 1/1] ShellPkg: Fix incorrect PPTT FlagName 
> dereference
>
> Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770)
>
> The PPTT parser in AcpiView incorrectly dereferences a pointer to
> FlagName when trying to log an error with the PPTT cache flags, which
> can lead to random crashes and other errors.
>
> Also fix some spacing in the error message to ensure the message is
> printed cleanly.
>
> Signed-off-by: Chris Jones <christopher.jones@arm.com>
> ---
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c 
> | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git 
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c 
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> index 
> 8d52bb5e4811298ddc45cdaef41150f6ee7819af..53777644580e779adab4e8047ea279e1c0de14a3 
> 100644
> --- 
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> +++ 
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
> @@ -40,9 +40,9 @@ LogCacheFlagError (
>    IncrementErrorCount ();
>    Print (
>      L"\nERROR: On Arm based systems, all cache properties must be"
> -    L"provided in the cache type structure."
> -    L"Missing '%s' flag.",
> -    *FlagName
> +    L" provided in the cache type structure."
> +    L" Missing '%s' flag.",
> +    FlagName
>      );
>  }
>
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>

[-- Attachment #2: Type: text/html, Size: 7285 bytes --]