Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror

[Laszlo Ersek <lersek@redhat.com>]

(+Liming)

OK, so the last comment on this patch was at:

http://mid.mail-archive.com/6800a51b-fa21-f325-bbc1-d17e3c8b62e2@redhat.com

Let's see the changes:


On 03/24/19 03:00, Rebecca Cran via edk2-devel wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>

This looks good. (The contributed-under line will soon become
unnecessary, but for now it's still required & correct, AIUI.)

> ---
>  Maintainers.txt | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index be77898ee2..4c9adf802b 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -40,10 +40,9 @@ Descriptions of section entries:
>  EDK II
>  ------
>  W: http://www.tianocore.org/edk2/

Any particular reason for dropping the website URL update?
<http://www.tianocore.org/edk2/> still redirects to
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II>, and your
previous patch (correctly) included that new URL.

> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
> +L: https://lists.01.org/mailman/listinfo/edk2-devel

This is the same as before, and it's good (we'll change this soon to
groups.io, I reckon, but for now it's good).

>  T: git - https://github.com/tianocore/edk2.git
>  T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2

Same as before, and also good.

>  T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>  
>  Tianocore Stewards
> 

So, if you dropped the "W:" change intentionally, I don't mind. After
all, the original link still works, and the patch is still a pure
improvement.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

If Liming too is OK with this patch (and you don't intend to update it),
I can help push it.

Thanks
Laszlo