From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DEFDB211E093D for ; Mon, 25 Mar 2019 04:49:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27E003164691; Mon, 25 Mar 2019 11:49:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-188.rdu2.redhat.com [10.10.120.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40F3E5DA63; Mon, 25 Mar 2019 11:49:44 +0000 (UTC) To: Rebecca Cran , edk2-devel@lists.01.org References: <20190324020033.50367-1-rebecca@bluestop.org> Cc: "Gao, Liming" From: Laszlo Ersek Message-ID: <3c86c1a6-eca6-33f2-6c54-b79e87d38019@redhat.com> Date: Mon, 25 Mar 2019 12:49:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190324020033.50367-1-rebecca@bluestop.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 25 Mar 2019 11:49:53 +0000 (UTC) Subject: Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 11:49:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (+Liming) OK, so the last comment on this patch was at: http://mid.mail-archive.com/6800a51b-fa21-f325-bbc1-d17e3c8b62e2@redhat.com Let's see the changes: On 03/24/19 03:00, Rebecca Cran via edk2-devel wrote: > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Rebecca Cran This looks good. (The contributed-under line will soon become unnecessary, but for now it's still required & correct, AIUI.) > --- > Maintainers.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index be77898ee2..4c9adf802b 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -40,10 +40,9 @@ Descriptions of section entries: > EDK II > ------ > W: http://www.tianocore.org/edk2/ Any particular reason for dropping the website URL update? still redirects to , and your previous patch (correctly) included that new URL. > -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel > +L: https://lists.01.org/mailman/listinfo/edk2-devel This is the same as before, and it's good (we'll change this soon to groups.io, I reckon, but for now it's good). > T: git - https://github.com/tianocore/edk2.git > T: git (mirror) - https://bitbucket.org/tianocore/edk2.git > -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2 Same as before, and also good. > T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2 > > Tianocore Stewards > So, if you dropped the "W:" change intentionally, I don't mind. After all, the original link still works, and the patch is still a pure improvement. Reviewed-by: Laszlo Ersek If Liming too is OK with this patch (and you don't intend to update it), I can help push it. Thanks Laszlo