public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>,
	"Luo, Heng" <heng.luo@intel.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment
Date: Tue, 7 Apr 2020 03:37:11 +0000	[thread overview]
Message-ID: <3c95986ac78541deafb786d1ae75a1ed@intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C4DDA39@SHSMSX104.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]

Hi Sean,

That the Basetools works correctly depends on the PACAKGES_PATH is set correctly. I think this patch provides common function and provides assistance for the Basetools.

Thanks,
Bob

From: Ni, Ray
Sent: Tuesday, April 7, 2020 10:16 AM
To: devel@edk2.groups.io; sean.brogan@microsoft.com; Luo, Heng <heng.luo@intel.com>
Cc: Feng, Bob C <bob.c.feng@intel.com>
Subject: RE: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

Sean,
PyTools is good. This patch is to support those platforms that haven’t adopted PyTools for their platform build.

Thanks,
Ray

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Sean via groups.io
Sent: Thursday, April 2, 2020 11:59 PM
To: Luo, Heng <heng.luo@intel.com<mailto:heng.luo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

I am not a fan of this.  The community and design meetings have had a few discussions about tools (PyTools has been presented twice) and a few brief discussions about common patterns to build platforms but I don't think there is real alignment.  Each "platform" has its own way of doing things.

As for this patch, I don't really want to see a bunch of scripts added to edk2 basetools that are not aligned with a community agreed direction (or any clear direction).  It has also been brought up that basetools as a python package/project is a challenge to work with and has some fundamental problems.  Adding more in a similar design pattern is not how we start fixing it.   As an example for edk2-pytools, an RFC was offered and even then it was added as its own repositories to avoid more directly to the edk2 repo.

@Mike K - Any progress on getting a tools subtream setup?  Any governance ideas to help align these efforts.

Thanks
Sean


[-- Attachment #2: Type: text/html, Size: 6081 bytes --]

  reply	other threads:[~2020-04-07  3:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  8:08 [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment Heng Luo
2020-04-02 15:59 ` [edk2-devel] " Sean
2020-04-07  2:15   ` Ni, Ray
2020-04-07  3:37     ` Bob Feng [this message]
2020-04-07  5:56       ` Sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c95986ac78541deafb786d1ae75a1ed@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox