From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.7780.1610451740826591366
 for <devel@edk2.groups.io>;
 Tue, 12 Jan 2021 03:42:21 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qj9xM3mS;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1610451740;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=B7xf7MRQMFr88VV/QQ5PQmZNwSJn2jMUvnORRjAVZhE=;
	b=Qj9xM3mSjPxSn9Zb6ebidw0tS5pAaHahLw+kAkdAcGp5EfkQ4a7Ykq31cwH7qEcUu5GLKk
	PgG7xsJPcWnE+PqxbDBhj5luSCbVLlcT86WJ694d9ijku0OltCAMOgpHFOTZVJZ2CtHMit
	e6prh993QvZNz7qVDS29Wwgxj90InK4=
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
 [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-39-G53trcjEPTydX9VrfzI4Bg-1; Tue, 12 Jan 2021 06:42:18 -0500
X-MC-Unique: G53trcjEPTydX9VrfzI4Bg-1
Received: by mail-wm1-f71.google.com with SMTP id r1so376291wmn.8
        for <devel@edk2.groups.io>; Tue, 12 Jan 2021 03:42:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=B7xf7MRQMFr88VV/QQ5PQmZNwSJn2jMUvnORRjAVZhE=;
        b=B9iKugU2bjuTgl6MP3vNOay0kDVCzeDvMPK0yjpkYHzptmofg9uYlCq65kALLswUrJ
         xghi0RCI3BezW2M32kgr7DWybYd/qjqOCoJZQqGbO5FnfIgI7M8NXU9ROF6w0PYoQhAW
         QslvpBW6UZuq9IBodgPSbxgxnpoifV8I5uiY26Yz3+ECZwulL2rno3HWyGCCTdIRXsmy
         oFUJu/LIAk5efhbZfVe3mR4F9fNBA04zLF7FxcRKkTiY6dYCEvlKIdHKyY2c1aU9z1C/
         X/1bU9UnAaeMGlDS9puV98autgdPZzrPqbv5Hm3nlIIy2LFtiVd2bqCg0WxGmScw9b1X
         +qAQ==
X-Gm-Message-State: AOAM530pzN9vlqAymGXSRxmlMUf5/V9cmv14Xt1G8ttqdmCvJrymvel3
	t0fnFpp1D0KAvEncxanQUruf8qBg+GqeAZFfEWTiPxGG/cLEOOL2IXF56coahDpsNuvcVEeL6qX
	0/bPYw9zQP3z8Bg==
X-Received: by 2002:a1c:c2d4:: with SMTP id s203mr3197607wmf.58.1610451737244;
        Tue, 12 Jan 2021 03:42:17 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyBXKWY23a1Gqwcg+Dk+bmhkrN9YTmLy2R+xPqS/jE7HaYt3kEwdMvW3F3WARRX00e4HpPkhg==
X-Received: by 2002:a1c:c2d4:: with SMTP id s203mr3197583wmf.58.1610451737058;
        Tue, 12 Jan 2021 03:42:17 -0800 (PST)
Return-Path: <philmd@redhat.com>
Received: from [192.168.1.36] (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190])
        by smtp.gmail.com with ESMTPSA id t16sm3794070wmi.3.2021.01.12.03.42.15
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Tue, 12 Jan 2021 03:42:16 -0800 (PST)
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg/NorFlashDxe: use correct PCD accessors
To: devel@edk2.groups.io, ard.biesheuvel@arm.com
Cc: leif@nuviainc.com,
 Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>,
 Masahisa Kojima <masahisa.kojima@linaro.org>,
 Sami Mujawar <sami.mujawar@arm.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20210111105719.18700-1-ard.biesheuvel@arm.com>
From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= <philmd@redhat.com>
Message-ID: <3c9fc9ef-30e0-5cf7-a64c-9cf40eaa69e9@redhat.com>
Date: Tue, 12 Jan 2021 12:42:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210111105719.18700-1-ard.biesheuvel@arm.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Ard,

On 1/11/21 11:57 AM, Ard Biesheuvel wrote:
> Commit 8015f3f6d4005d83 ("ArmPlatformPkg: Enable support for flash in
> 64-bit address space") updated the NorFlash DXE and StMM drivers to
> take alternate PCDs into account when discovering the base of the
> NOR flash regions.
> 
> This introduced a disparity between the declarations of the PCD references
> in the .INF files, which permits the use of dynamic PCDs, and the code
> itself, which now uses FixedPcdGet() accessors. On platforms that actually
> use dynamic PCDs, this results in a build error.

So there is no (mainstream) CI coverage for these platforms?
Could we add at least one?

Thanks,

Phil.