From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.38184.1612201736481954047 for ; Mon, 01 Feb 2021 09:48:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DAg6nRom; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612201735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JsiYwPxkJge6xrX0i6xtVmbHopfa3DcJufY72k1EJss=; b=DAg6nRompZ8tzU1sYqg4fMKEuq8bE9Ge3qRgFSPKI7P2s69UYV9BqduwewzRcwGkg4pgsS ykQe8KbxQtwwSWcnd9FdsKEpyBnDBpOVnPmYRPAvMQCZOhXiTd3gziOpOZuvkva9ORGHNs ZyMjDFYs//AHegBdRFYYxSNlXhlOxzQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-538-AirdO0vEOfKidD7BNRB6BA-1; Mon, 01 Feb 2021 12:48:53 -0500 X-MC-Unique: AirdO0vEOfKidD7BNRB6BA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D8D8802B48; Mon, 1 Feb 2021 17:48:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id 962A75D9DC; Mon, 1 Feb 2021 17:48:50 +0000 (UTC) Subject: Re: [PATCH v6 9/9] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug From: "Laszlo Ersek" To: Ankur Arora , devel@edk2.groups.io Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com, Jordan Justen , Ard Biesheuvel , Aaron Young References: <20210129005950.467638-1-ankur.a.arora@oracle.com> <20210129005950.467638-10-ankur.a.arora@oracle.com> <92a29bb5-fc0e-c11f-2702-07c7729a11b4@redhat.com> Message-ID: <3ceb6b24-a1ac-502e-5ebb-4fdfdc816d7a@redhat.com> Date: Mon, 1 Feb 2021 18:48:49 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/01/21 18:40, Laszlo Ersek wrote: > On 02/01/21 18:37, Laszlo Ersek wrote: >> On 01/29/21 01:59, Ankur Arora wrote: >>> As part of the negotiation treat ICH9_LPC_SMI_F_CPU_HOT_UNPLUG as a >>> subfeature of feature flag ICH9_LPC_SMI_F_CPU_HOTPLUG, so enable it >>> only if the other is also being negotiated. >>> >>> Cc: Laszlo Ersek >>> Cc: Jordan Justen >>> Cc: Ard Biesheuvel >>> Cc: Igor Mammedov >>> Cc: Boris Ostrovsky >>> Cc: Aaron Young >>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3132 >>> Signed-off-by: Ankur Arora >>> --- >>> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 25 ++++++++++++++++++++++--- >>> 1 file changed, 22 insertions(+), 3 deletions(-) [...] >>> @@ -120,8 +128,18 @@ NegotiateSmiFeatures ( >>> // For now, we only support hotplug with SEV disabled. >>> // >>> RequestedFeaturesMask |= ICH9_LPC_SMI_F_CPU_HOTPLUG; >>> + RequestedFeaturesMask |= ICH9_LPC_SMI_F_CPU_HOT_UNPLUG; >>> } >>> mSmiFeatures &= RequestedFeaturesMask; >>> + >>> + if (!(mSmiFeatures & ICH9_LPC_SMI_F_CPU_HOTPLUG) && >>> + (mSmiFeatures & ICH9_LPC_SMI_F_CPU_HOT_UNPLUG)) { >>> + DEBUG ((DEBUG_WARN, "%a CPU host-features %Lx, requested mask %Lx\n", >>> + __FUNCTION__, mSmiFeatures, RequestedFeaturesMask)); >>> + >>> + mSmiFeatures &= ~ICH9_LPC_SMI_F_CPU_HOT_UNPLUG; >>> + } >>> + >>> QemuFwCfgSelectItem (mRequestedFeaturesItem); >>> QemuFwCfgWriteBytes (sizeof mSmiFeatures, &mSmiFeatures); >>> >> >> (6) Please drop this hunk. We don't try to be smarter than QEMU, in >> general, whenever we perform feature negotiation. (8) ... Please refresh the commit message accordingly. > ... obviously: don't drop the part where you set the new bit! :) Sorry, > "hunk" was not the correct term. Thanks! Laszlo