From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C253ED802D7 for ; Wed, 18 Oct 2023 15:19:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hjl/wuBFch/ngjZfUYeAO+vZPhzw5EGrFasw0RFfcwI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697642387; v=1; b=s5JejxJS1wUqQVRKBn++8K/yIfM9a9/vgZpU+7b5GG9VGXSfp6VSj05h8t2lI5sD4BbdIsJW 93RuucV5khv9gyFvxKDM6qMlhvpzStqoqi6fvQLTvwuXKyLHM0N4aWz1Ov7GqIDxgin7c2PivOj 3IYxn468kQj4nam3W7JLy6bo= X-Received: by 127.0.0.2 with SMTP id yiQLYY7687511xfqCtqzOBZZ; Wed, 18 Oct 2023 08:19:47 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.283859.1697642386691393830 for ; Wed, 18 Oct 2023 08:19:46 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-413-glcs7XUQPX25KzT1d2m8tg-1; Wed, 18 Oct 2023 11:19:42 -0400 X-MC-Unique: glcs7XUQPX25KzT1d2m8tg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3145388D024; Wed, 18 Oct 2023 15:19:42 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 458AD1C060AE; Wed, 18 Oct 2023 15:19:41 +0000 (UTC) Message-ID: <3cf51c44-a14f-c10c-4131-905ed81660d6@redhat.com> Date: Wed, 18 Oct 2023 17:19:39 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/5] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename LibRtcVirtualNotifyEvent To: Sami Mujawar , "devel@edk2.groups.io" Cc: Ray Ni , nd References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012091057.108728-1-lersek@redhat.com> <20231012091057.108728-2-lersek@redhat.com> <2912F689-CF79-45EB-8911-92B99B41238A@arm.com> <7E36E369-2BA1-443F-B992-87F233C713D1@arm.com> From: "Laszlo Ersek" In-Reply-To: <7E36E369-2BA1-443F-B992-87F233C713D1@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ghEemM0k3tab10tjgRlTc36dx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=s5JejxJS; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 10/18/23 17:15, Sami Mujawar wrote: > Hi Laszlo, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/10/2023, 14:42, "Laszlo Ersek" > wrote: > > > Hi Sami, > > > On 10/12/23 14:33, Sami Mujawar wrote: >> Hi Laszlo, >> >> Thank you for this patch. >> These changes look good to me. >> >> Reviewed-by: Sami Mujawar > >> >> Tested by booting a Linux guest using Kvmtool guest firmware (ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64. >> Tested-by: Sami Mujawar > > > > your response is under a PcAtChipsetPkg patch -- that's not used in > "ArmVirtPkg/ArmVirtKvmTool.dsc". > > > Which patches did you mean your Tested-by for? > [SAMI] Sorry for not being clear. PcatRealTimeClockRuntimeDxe is used by the Kvmtool guest firmware, > please see https://github.com/tianocore/edk2/blob/master/ArmVirtPkg/ArmVirtKvmTool.dsc#L285-L288 > I have applied this patch and tested that it works for the Kvmtool guest firmware. > [/SAMI] And right you are! Wow... that's unexpected of ArmVirtPkg content! Thanks! Laszlo > > Thanks! > Laszlo > > >> >> Regards, >> >> Sami Mujawar >> >> On 12/10/2023, 10:25, "devel@edk2.groups.io > on behalf of Laszlo Ersek via groups.io" > on behalf of lersek=redhat.com@groups.io >> wrote: >> >> >> PcatRealTimeClockRuntimeDxe seems to have copied the interface name >> LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. >> That's not right, for two reasons: >> >> >> - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the >> first place, >> >> >> - in EmbeddedPkg, the RealTimeClockLib class API >> LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). >> >> >> Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), >> and make it static. >> >> >> Tested with booting OVMF. >> >> >> Cc: Ray Ni >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >> Signed-off-by: Laszlo Ersek >> >> --- >> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> >> diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c >> index b600df487952..ca0cad9b0198 100644 >> --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c >> +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c >> @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime ( >> @param[in] Event The Event that is being processed >> @param[in] Context Event Context >> **/ >> +STATIC >> VOID >> EFIAPI >> -LibRtcVirtualNotifyEvent ( >> +VirtualNotifyEvent ( >> IN EFI_EVENT Event, >> IN VOID *Context >> ) >> @@ -220,7 +221,7 @@ InitializePcRtc ( >> Status = gBS->CreateEventEx ( >> EVT_NOTIFY_SIGNAL, >> TPL_NOTIFY, >> - LibRtcVirtualNotifyEvent, >> + VirtualNotifyEvent, >> NULL, >> &gEfiEventVirtualAddressChangeGuid, >> &mVirtualAddrChangeEvent >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109764): https://edk2.groups.io/g/devel/message/109764 Mute This Topic: https://groups.io/mt/101914676/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-