[edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

[edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

[Xiaoyao Li]

For TDCALL leaf TDG.VP.INFO, the bit 31:0 in R8 returns NUM_VCPUS and
bit 63:32 in R8 returns MAX_VCPUS. Current struct
TDCALL_INFO_RETURN_DATA defines them in wrong order.

Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
---
 MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Tdx.h b/MdePkg/Include/IndustryStandard/Tdx.h
index 2662761883e5..17f1e8f4146a 100644
--- a/MdePkg/Include/IndustryStandard/Tdx.h
+++ b/MdePkg/Include/IndustryStandard/Tdx.h
@@ -113,8 +113,8 @@ typedef struct {
 typedef struct {
   UINT64    Gpaw;
   UINT64    Attributes;
-  UINT32    MaxVcpus;
   UINT32    NumVcpus;
+  UINT32    MaxVcpus;
   UINT64    Resv[3];
 } TDCALL_INFO_RETURN_DATA;
 
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119726): https://edk2.groups.io/g/devel/message/119726
Mute This Topic: https://groups.io/mt/106918890/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

[gaoliming via groups.io]

Is there Pull Request for this patch?

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Xiaoyao Li
> 发送时间: 2024年6月27日 9:27
> 收件人: devel@edk2.groups.io
> 抄送: xiaoyao.li@intel.com
> 主题: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and
> MaxVcpus
> 
> For TDCALL leaf TDG.VP.INFO, the bit 31:0 in R8 returns NUM_VCPUS and
> bit 63:32 in R8 returns MAX_VCPUS. Current struct
> TDCALL_INFO_RETURN_DATA defines them in wrong order.
> 
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
>  MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Tdx.h
> b/MdePkg/Include/IndustryStandard/Tdx.h
> index 2662761883e5..17f1e8f4146a 100644
> --- a/MdePkg/Include/IndustryStandard/Tdx.h
> +++ b/MdePkg/Include/IndustryStandard/Tdx.h
> @@ -113,8 +113,8 @@ typedef struct {
>  typedef struct {
> 
>    UINT64    Gpaw;
> 
>    UINT64    Attributes;
> 
> -  UINT32    MaxVcpus;
> 
>    UINT32    NumVcpus;
> 
> +  UINT32    MaxVcpus;
> 
>    UINT64    Resv[3];
> 
>  } TDCALL_INFO_RETURN_DATA;
> 
> 
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#119726): https://edk2.groups.io/g/devel/message/119726
> Mute This Topic: https://groups.io/mt/106918890/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119767): https://edk2.groups.io/g/devel/message/119767
Mute This Topic: https://groups.io/mt/107012181/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: 回复: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

[Xiaoyao Li]

On 7/3/2024 9:12 AM, gaoliming wrote:
> Is there Pull Request for this patch?

yes.

https://github.com/tianocore/edk2/pull/5828

>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Xiaoyao Li
>> 发送时间: 2024年6月27日 9:27
>> 收件人: devel@edk2.groups.io
>> 抄送: xiaoyao.li@intel.com
>> 主题: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and
>> MaxVcpus
>>
>> For TDCALL leaf TDG.VP.INFO, the bit 31:0 in R8 returns NUM_VCPUS and
>> bit 63:32 in R8 returns MAX_VCPUS. Current struct
>> TDCALL_INFO_RETURN_DATA defines them in wrong order.
>>
>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> ---
>>   MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MdePkg/Include/IndustryStandard/Tdx.h
>> b/MdePkg/Include/IndustryStandard/Tdx.h
>> index 2662761883e5..17f1e8f4146a 100644
>> --- a/MdePkg/Include/IndustryStandard/Tdx.h
>> +++ b/MdePkg/Include/IndustryStandard/Tdx.h
>> @@ -113,8 +113,8 @@ typedef struct {
>>   typedef struct {
>>
>>     UINT64    Gpaw;
>>
>>     UINT64    Attributes;
>>
>> -  UINT32    MaxVcpus;
>>
>>     UINT32    NumVcpus;
>>
>> +  UINT32    MaxVcpus;
>>
>>     UINT64    Resv[3];
>>
>>   } TDCALL_INFO_RETURN_DATA;
>>
>>
>>
>> --
>> 2.34.1
>>
>>
>>
>> -=-=-=-=-=-=
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#119726): https://edk2.groups.io/g/devel/message/119726
>> Mute This Topic: https://groups.io/mt/106918890/4905953
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub
>> [gaoliming@byosoft.com.cn]
>> -=-=-=-=-=-=
>>
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119769): https://edk2.groups.io/g/devel/message/119769
Mute This Topic: https://groups.io/mt/107012181/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-