From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.60]) by mx.groups.io with SMTP id smtpd.web08.33890.1605041820259123850 for ; Tue, 10 Nov 2020 12:57:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=qP0Rx+g3; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.93.60, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0kXIQrAPv30Lb/Df13wWZag6xRj9K5Wqv6NqCg/akrdj0lip9C9ZCkPGyblVngQgsgeP4hAGezouQgB6yzq7yNbWfHcEys36331On4VrpRyhjtm2p3fUlaKsnBRi6lFm5IvmilX9twS0ZyFQZY1wgAEQBhKvcAs/mIs31u0JztLzjW8BCcLwQma2Z8jstpXvy2uGcAn/1DiSO1UlgSx6nzJDMxR4/uwZr0wa63+i6aM1EQn8x2aIVTHAN43OanyOZglUxBBdTqAWRjpRkmLsNCUXQ5JqWWJwU6x0+XiVMXoQDL8XJvsqPT/6VfBwOUmE+dU8jfq3Ij64ASIDEN8bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AzJx2ZsZ2pNIZrxb2RqqZQfStO77cVKemmdGH3Igyg8=; b=jOLoU+HtpK6NWNDyKjIKPWkWlM6Khllay2J2e5cyL1Hd7TovM8VBkWxgHYo0xsYkVaVuuII0FkSP8oNOEILWwdGl4LQ35Y51GocyCTb0s66sxxHC/WYnbrVOlbZmOQDkosS5jA/6D1IZQScdnPz3XCY55utymrt/AHzMLn9mO/FPHo9PGR6I166pAizaudBbHdzRBfCHD6Rvo37/a+TwL8aeuIDDu9EetdwsuICrh5PlLswEkl6H8t8sFe6PmwKdwKLLGf4LNRH9NHerTtVfDak05v5YT4wFhA9zh8JgOSvspafDH63ljj18ZZtX+4Hxz7TTpIBFVaZHNIf122yapA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AzJx2ZsZ2pNIZrxb2RqqZQfStO77cVKemmdGH3Igyg8=; b=qP0Rx+g3wCkq+L+CaqJCprmAevgRX1q43/87MMfdocUuMgrzCY9ZQAkM0OFrxziulfva8fxxLJbjTx1i/CW8fzcFdbc7a7kwjrLpEiN6wOM8adLmezTk4UrRlKMT7UaZ6fakCnXGGLzb9DDZ4tuEsH5SXZt14yjHP7lswLrh6bA= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (10.168.234.7) by DM6PR12MB4942.namprd12.prod.outlook.com (20.179.226.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 20:56:58 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::e442:c052:8a2c:5fba%6]) with mapi id 15.20.3499.034; Tue, 10 Nov 2020 20:56:58 +0000 Subject: Re: [edk2-devel] [PATCH.V3] BaseTools: Incremental build issue for included ASI file's deletion. To: devel@edk2.groups.io, bob.c.feng@intel.com, "Liang, MingyueX" Cc: Liming Gao , "Chen, Christine" References: <20201109025121.1269-1-mingyuex.liang@intel.com> <1645C293A820CE46.8542@groups.io> From: "Lendacky, Thomas" Message-ID: <3cfe7e5e-bd1b-e872-5a9f-1fd960ba446c@amd.com> Date: Tue, 10 Nov 2020 14:56:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN2PR01CA0071.prod.exchangelabs.com (2603:10b6:800::39) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.118] (165.204.77.1) by SN2PR01CA0071.prod.exchangelabs.com (2603:10b6:800::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25 via Frontend Transport; Tue, 10 Nov 2020 20:56:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b6567144-bf04-4a8a-fb85-08d885bb29db X-MS-TrafficTypeDiagnostic: DM6PR12MB4942: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:612; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E9RxFC1WnNrlCwOjmYI+LFTOyXQISnJo+vD6WTkq8Lb4OBAImFk8A501ns5kkXzd9iaHapbncjsyiBGz1KNwJTWZ7YyBL4SodlUIrtWgq0PDQfWcwYyH/lAK6dWr8T/7r0uO6Cc6601+VSp97f2oveIu7Y2oA/DDJpKDZeQWa/QDjZ/a1RsUp5NphJBlcTGJVVf7YpevZcP2z/GxCWCCExu8RejZXFrE+mFV3/p9iaqBohgXFaYrblk8qsSLtkY0K05DZtGN1ihuphl4V6+WjXdzDIy2WAxBli7ZQglhQjqyaU5EN7htyhwMI9OYg0ev+dNRKa5TKG3JJzvgk5w6fIOTmJQfeDDTDYXZOx37bo0xt+nAhy19hpdNByo1t4JKOXikpNUok4cJrnVuCE9BnzWXuRwX+OUoTbY8sBJaMFrZa2oDlu3lsv1hf6sXGIglct6JZZBLRu4y/ELYoL0Zuo8pcpwfK8ZLe6FSjsgqMKA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(956004)(5660300002)(316002)(31686004)(36756003)(6486002)(4326008)(478600001)(16526019)(186003)(2616005)(2906002)(83380400001)(6916009)(66556008)(66476007)(66946007)(45080400002)(53546011)(26005)(52116002)(966005)(86362001)(8936002)(8676002)(54906003)(31696002)(16576012)(21314003)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VLk3tUqXfKyMURnQ9UJYVp5/MveOK7i5V0nMAp7l5J3aVEIvvVOvsjc3KuURpxHeT4jhL3YHCBwrJeouNENGyDxUjtlqDlrxkdGx4eTNUh4iyJ/7GVcWPuERoer6hr6E8lvdWMvWwqIwZkb+IcrkcBln7TGbaUqNvVcdET2Imodptuo3VPd12wb56oAE/Ul+RRohxivZ957JfW0PEJfHnoiFRO3zEtzdz0ILbKi/37wrWLCT/AoNfN+5hy4LliG73lJ+cLGEenxpsWqzNYbIxf4PsT8WrzVUfhOrFD0zn6/EJ5OAL3hhQvRLSCrBIv01dJUenbrie8ILLqqo2iTcSTp64CNlJGsvyckmDWZVhOcwmiJzGVvlb9UKCSmC223gHqdYKPdPeWxNahKR6xpMmvjRD2z509y6eYnKeUM7cqDpHVw301PhWu/6eC0e3Xx71KS2bORzSbm4IQuQpoy13wOQF9y/VCZNXKb1h9xjmyIAYjK0eqFldDqChu+qJWC5B7HDgBCfZgHeAu5YLJ2va37FTtLgPcDYxxgXBp+bXXK4GWADOZZnZGna7aNKzqaouixyV4gVTP6Bez6acZAH38/0t56OaDsTnCDuCOf9h74k234c9BDSoZSEKDmIy3Woi9fccs/lCEOs4+I1ZruoUw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6567144-bf04-4a8a-fb85-08d885bb29db X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 20:56:58.3525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Q5Qce6PPxcqz1SGRmIZ4rcMRHow2rwXZG0ziSy/FDsWspiEUGVKLyScoqEgO+j29079JjpLjhEx4KFUlhzu2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4942 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit After doing a git pull today, I started seeing these (error) messages in my build: build.py... : error 000E: /root/kernels/ovmf-build-X64/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/Dsdt.asl.trim.deps doesn't exist list index out of range build.py... : error 000E: /root/kernels/ovmf-build-X64/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/Ssdt.asl.trim.deps doesn't exist list index out of range Building ... /root/kernels/ovmf-build-X64/NetworkPkg/Library/DxeNetLib/DxeNetLib.inf [X64] build.py... : error 000E: /root/kernels/ovmf-build-X64/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/Dsdt.asl.trim.deps doesn't exist list index out of range build.py... : error 000E: /root/kernels/ovmf-build-X64/Build/OvmfX64/DEBUG_GCC5/X64/OvmfPkg/AcpiTables/AcpiTables/OUTPUT/Ssdt.asl.trim.deps doesn't exist list index out of range I bisected it to this commit. The build completes successfully, however. So is this just an "error" that is really just informational? Thanks, Tom On 11/9/20 6:21 PM, Bob Feng via groups.io wrote: > Created the PR https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F1102&data=04%7C01%7Cthomas.lendacky%40amd.com%7C489d34e5582a4ca1766608d8850e9b7c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637405645077123886%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GcAFjR3rpnnRUzbDWhO5FaWki0kMCTBMpZLlzixkQ00%3D&reserved=0 > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Monday, November 9, 2020 2:20 PM > To: Liang, MingyueX ; devel@edk2.groups.io > Cc: Liming Gao ; Chen, Christine > Subject: Re: [edk2-devel] [PATCH.V3] BaseTools: Incremental build issue for included ASI file's deletion. > > Reviewed-by: Bob Feng > > -----Original Message----- > From: Mingyue Liang > Sent: Monday, November 9, 2020 10:51 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Liming Gao ; Chen, Christine > Subject: [PATCH.V3] BaseTools: Incremental build issue for included ASI file's deletion. > > REF:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2972&data=04%7C01%7Cthomas.lendacky%40amd.com%7C489d34e5582a4ca1766608d8850e9b7c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637405645077123886%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dXdFf1EciwOH0PvZ%2BgmOeuAxOFULi3TXUFbYO1dR2O4%3D&reserved=0 > > When using incremental build to delete an included xxx.asi file from the ASL file, the xxx.asl.trim.deps file generated by previous build process will not be deleted from the OUTPUT directory, which caused the dependency file still include the xxx.asl.trim.deps file. > > If the include file is deleted and DEPs is empty. > > Signed-off-by: Mingyue Liang > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > --- > V3: > Modify Version Description location. > > BaseTools/Source/Python/Trim/Trim.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Python/Trim/Trim.py > index 776474b20349..c479f7d2b2e7 100644 > --- a/BaseTools/Source/Python/Trim/Trim.py > +++ b/BaseTools/Source/Python/Trim/Trim.py > @@ -372,8 +372,7 @@ def TrimAslFile(Source, Target, IncludePathFile,AslDeps = False): > AslIncludes = [] > Lines = DoInclude(Source, '', IncludePathList,IncludeFileList=AslIncludes,filetype='ASL') > AslIncludes = [item for item in AslIncludes if item !=Source] > - if AslDeps and AslIncludes: > - SaveFileOnChange(os.path.join(os.path.dirname(Target),os.path.basename(Source))+".trim.deps", " \\\n".join([Source+":"] +AslIncludes),False) > + > + SaveFileOnChange(os.path.join(os.path.dirname(Target),os.path.basename > + (Source))+".trim.deps", " \\\n".join([Source+":"] +AslIncludes),False) > > # > # Undef MIN and MAX to avoid collision in ASL source code > -- > 2.29.2.windows.2 > > > > > > > > > > >