Re: [edk2-devel] [PATCH v2 5/5] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

["Laszlo Ersek" <lersek@redhat.com>]

On 02/26/20 01:40, Laszlo Ersek wrote:
> On 02/25/20 11:44, Ard Biesheuvel wrote:
>> Duplicate the TPM2_ENABLE and TPM2_CONFIG_ENABLE build time flags that
>> already exist in OvmfPkg, and wire them up in the .DSC and .FDF so
>> that setting those flags produces a ArmVirtQemu build that implements
>> measured boot using a TPM provided by QEMU and described in the device
>> tree.
>>
>> Note that the TPM2 driver stack relies on a PEI phase being implemented,
>> so there is no point in enabling this for ArmVirtQemuKernel or ArmVirtXen.
>>
>> Also note that, despite ArmVirtQemuKernel being unaffected by this patch,
>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc is being modified, for keeping the
>> contexts of the referring !include directives simple.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirtQemu.dsc           | 75 ++++++++++++++++++++
>>  ArmVirtPkg/ArmVirtQemu.fdf           |  6 ++
>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 10 +++
>>  3 files changed, 91 insertions(+)
> 
> Under a similar, recent patch from Marc-André (which proposes enabling
> TPM-1.2 in OvmfPkg), I asked Marc-André to build up the work in small
> steps, practically mirroring the gradual TPM2.0 stuff from OvmfPkg:
> 
> * [edk2-devel] [PATCH v2 3/3] Ovmf: enable TPM 1.2 support
> 
> http://mid.mail-archive.com/bbf8cf87-9c90-5507-82b3-ae8534555a54@redhat.com
> 
> https://edk2.groups.io/g/devel/message/54473
> 
> I'd like to be consistent as a review (and I indeed prefer that
> approach), so I'd like to ask you for the same.

Please see the approach here:

[PATCH v3 0/6] Ovmf: enable TPM 1.2

https://edk2.groups.io/g/devel/message/54854
http://mid.mail-archive.com/20200226093459.1131530-1-marcandre.lureau@redhat.com

Thanks!
Laszlo