From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: Anthony Perard <anthony.perard@citrix.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Brijesh Singh <brijesh.singh@amd.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
Gerd Hoffmann <kraxel@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>, "Xu, Min M" <min.m.xu@intel.com>,
Peter Grehan <grehan@freebsd.org>,
Rebecca Cran <rebecca@bsdio.com>,
"Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v5 7/8] OvmfPkg: Add VariableFlashInfoLib
Date: Mon, 25 Apr 2022 22:27:44 -0400 [thread overview]
Message-ID: <3d3ced20-261b-271f-f7e8-891e52f59393@linux.microsoft.com> (raw)
In-Reply-To: <MW4PR11MB587224677D3D1E1D1272D3C68CFB9@MW4PR11MB5872.namprd11.prod.outlook.com>
Thanks Jiewen. I added this R-b (and all others) to the V5 PR here:
https://github.com/tianocore/edk2/pull/2828
Regards,
Michael
On 4/25/2022 10:14 PM, Yao, Jiewen wrote:
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
>> Kubacki
>> Sent: Tuesday, April 26, 2022 9:29 AM
>> To: devel@edk2.groups.io
>> Cc: Anthony Perard <anthony.perard@citrix.com>; Ard Biesheuvel
>> <ardb+tianocore@kernel.org>; Brijesh Singh <brijesh.singh@amd.com>; Aktas,
>> Erdem <erdemaktas@google.com>; Gerd Hoffmann <kraxel@redhat.com>;
>> James Bottomley <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>;
>> Justen, Jordan L <jordan.l.justen@intel.com>; Julien Grall <julien@xen.org>; Xu,
>> Min M <min.m.xu@intel.com>; Peter Grehan <grehan@freebsd.org>; Rebecca
>> Cran <rebecca@bsdio.com>; Boeuf, Sebastien <sebastien.boeuf@intel.com>;
>> Tom Lendacky <thomas.lendacky@amd.com>; Ard Biesheuvel
>> <ardb@kernel.org>; Gao, Liming <gaoliming@byosoft.com.cn>
>> Subject: [edk2-devel] [PATCH v5 7/8] OvmfPkg: Add VariableFlashInfoLib
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
>>
>> Adds an instance of VariableFlashInfoLib to the platform build as
>> it is a new library class introduced in MdeModulePkg.
>>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: Erdem Aktas <erdemaktas@google.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien@xen.org>
>> Cc: Min Xu <min.m.xu@intel.com>
>> Cc: Peter Grehan <grehan@freebsd.org>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Sebastien Boeuf <sebastien.boeuf@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
>> OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
>> OvmfPkg/CloudHv/CloudHvX64.dsc | 1 +
>> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 +
>> OvmfPkg/Microvm/MicrovmX64.dsc | 1 +
>> OvmfPkg/OvmfPkgIa32.dsc | 1 +
>> OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
>> OvmfPkg/OvmfPkgX64.dsc | 1 +
>> OvmfPkg/OvmfXen.dsc | 1 +
>> 9 files changed, 9 insertions(+)
>>
>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc
>> b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> index f0700035c116..bead9722eab8 100644
>> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
>> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
>> @@ -196,6 +196,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>> !if $(BUILD_SHELL) == TRUE
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
>> index a8fa4d38ab60..d33728cbe773 100644
>> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
>> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
>> @@ -207,6 +207,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>> #
>> # Network libraries
>> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc
>> b/OvmfPkg/CloudHv/CloudHvX64.dsc
>> index d1c85f60c768..92664f319be2 100644
>> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
>> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
>> @@ -217,6 +217,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> index 73a6c30096a8..01e0ae0ad40a 100644
>> --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc
>> @@ -185,6 +185,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc
>> b/OvmfPkg/Microvm/MicrovmX64.dsc
>> index 20c3c9c4d862..f8fc977cb205 100644
>> --- a/OvmfPkg/Microvm/MicrovmX64.dsc
>> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
>> @@ -207,6 +207,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>> index f02b371f7427..892ed6c64cf1 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -214,6 +214,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>> index cb68e612bd35..d3a80cb56892 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -218,6 +218,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>> index 45ffa2dbe35f..c05f345a40e1 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -226,6 +226,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
>> index a1626d06dfc3..6ba4bd729ae7 100644
>> --- a/OvmfPkg/OvmfXen.dsc
>> +++ b/OvmfPkg/OvmfXen.dsc
>> @@ -196,6 +196,7 @@ [LibraryClasses]
>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>
>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in
>> f
>>
>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab
>> lePolicyHelperLib.inf
>> +
>> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar
>> iableFlashInfoLib.inf
>>
>>
>> #
>> --
>> 2.28.0.windows.1
>>
>>
>>
>> -=-=-=-=-=-=
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#89304): https://edk2.groups.io/g/devel/message/89304
>> Mute This Topic: https://groups.io/mt/90699684/1772286
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com]
>> -=-=-=-=-=-=
>>
>
>
>
>
>
next prev parent reply other threads:[~2022-04-26 2:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 1:29 [PATCH v5 0/8] Add Variable Flash Info HOB Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 1/8] MdeModulePkg: " Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 2/8] MdeModulePkg/VariableFlashInfoLib: Add initial library Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 3/8] MdeModulePkg/Variable: Consume Variable Flash Info Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 4/8] MdeModulePkg/FaultTolerantWrite: " Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 5/8] ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 6/8] EmulatorPkg: " Michael Kubacki
2022-04-26 1:29 ` [PATCH v5 7/8] OvmfPkg: " Michael Kubacki
2022-04-26 2:14 ` [edk2-devel] " Yao, Jiewen
2022-04-26 2:27 ` Michael Kubacki [this message]
2022-04-26 1:29 ` [PATCH v5 8/8] UefiPayloadPkg: " Michael Kubacki
2022-04-29 13:45 ` [PATCH v5 0/8] Add Variable Flash Info HOB Ard Biesheuvel
2022-04-29 15:48 ` Michael Kubacki
2022-05-05 1:27 ` 回复: [edk2-devel] " gaoliming
2022-05-06 1:52 ` Michael Kubacki
2022-05-10 15:01 ` Michael Kubacki
2022-05-13 18:23 ` Michael Kubacki
2022-05-14 1:16 ` 回复: " gaoliming
2022-05-16 15:27 ` Michael Kubacki
2022-05-16 17:36 ` Ard Biesheuvel
2022-05-17 4:14 ` Michael Kubacki
2022-05-17 5:22 ` 回复: " gaoliming
2022-05-17 13:06 ` Michael Kubacki
2022-05-17 16:10 ` Michael Kubacki
2022-05-19 3:45 ` 回复: " gaoliming
[not found] ` <16F064E8C9D4EA0D.2722@groups.io>
2022-05-19 6:20 ` gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3ced20-261b-271f-f7e8-891e52f59393@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox