From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.1497.1650940068439287169 for ; Mon, 25 Apr 2022 19:27:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=oOJhtr2l; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id A7CF520E8CB0; Mon, 25 Apr 2022 19:27:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A7CF520E8CB0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1650940067; bh=SOENDzHGBrjcDf5SPOpd9lbgCZVohW8zRhLL0UiQUQ4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oOJhtr2lnP/z4L1z3a1dFYNdIKXYHZArQrEZBwHFF4Q6G9WLRZ2qQ5oh8egFGedeY r40uEUw7t4pcGjETn6L4Bsa70RxCAn2Ic68gEjnkiKbRUC9a3fKoCBjq2wtR2XIXHZ MYGqjouW1fEBXfm4V1F/bWDWE89xXZYmYYgRSEuQ= Message-ID: <3d3ced20-261b-271f-f7e8-891e52f59393@linux.microsoft.com> Date: Mon, 25 Apr 2022 22:27:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [edk2-devel] [PATCH v5 7/8] OvmfPkg: Add VariableFlashInfoLib To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: Anthony Perard , Ard Biesheuvel , Brijesh Singh , "Aktas, Erdem" , Gerd Hoffmann , James Bottomley , "Justen, Jordan L" , Julien Grall , "Xu, Min M" , Peter Grehan , Rebecca Cran , "Boeuf, Sebastien" , Tom Lendacky , Ard Biesheuvel , "Gao, Liming" References: <20220426012918.1216-1-mikuback@linux.microsoft.com> <20220426012918.1216-8-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Jiewen. I added this R-b (and all others) to the V5 PR here: https://github.com/tianocore/edk2/pull/2828 Regards, Michael On 4/25/2022 10:14 PM, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Tuesday, April 26, 2022 9:29 AM >> To: devel@edk2.groups.io >> Cc: Anthony Perard ; Ard Biesheuvel >> ; Brijesh Singh ; Aktas, >> Erdem ; Gerd Hoffmann ; >> James Bottomley ; Yao, Jiewen ; >> Justen, Jordan L ; Julien Grall ; Xu, >> Min M ; Peter Grehan ; Rebecca >> Cran ; Boeuf, Sebastien ; >> Tom Lendacky ; Ard Biesheuvel >> ; Gao, Liming >> Subject: [edk2-devel] [PATCH v5 7/8] OvmfPkg: Add VariableFlashInfoLib >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 >> >> Adds an instance of VariableFlashInfoLib to the platform build as >> it is a new library class introduced in MdeModulePkg. >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Brijesh Singh >> Cc: Erdem Aktas >> Cc: Gerd Hoffmann >> Cc: James Bottomley >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Julien Grall >> Cc: Min Xu >> Cc: Peter Grehan >> Cc: Rebecca Cran >> Cc: Sebastien Boeuf >> Cc: Tom Lendacky >> Signed-off-by: Michael Kubacki >> Acked-by: Ard Biesheuvel >> Reviewed-by: Liming Gao >> Reviewed-by: Rebecca Cran >> --- >> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + >> OvmfPkg/Bhyve/BhyveX64.dsc | 1 + >> OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + >> OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + >> OvmfPkg/Microvm/MicrovmX64.dsc | 1 + >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfXen.dsc | 1 + >> 9 files changed, 9 insertions(+) >> >> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc >> b/OvmfPkg/AmdSev/AmdSevX64.dsc >> index f0700035c116..bead9722eab8 100644 >> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc >> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc >> @@ -196,6 +196,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> !if $(BUILD_SHELL) == TRUE >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc >> index a8fa4d38ab60..d33728cbe773 100644 >> --- a/OvmfPkg/Bhyve/BhyveX64.dsc >> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc >> @@ -207,6 +207,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> # >> # Network libraries >> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc >> b/OvmfPkg/CloudHv/CloudHvX64.dsc >> index d1c85f60c768..92664f319be2 100644 >> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc >> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc >> @@ -217,6 +217,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> diff --git a/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> b/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> index 73a6c30096a8..01e0ae0ad40a 100644 >> --- a/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> +++ b/OvmfPkg/IntelTdx/IntelTdxX64.dsc >> @@ -185,6 +185,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf >> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc >> b/OvmfPkg/Microvm/MicrovmX64.dsc >> index 20c3c9c4d862..f8fc977cb205 100644 >> --- a/OvmfPkg/Microvm/MicrovmX64.dsc >> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc >> @@ -207,6 +207,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc >> index f02b371f7427..892ed6c64cf1 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -214,6 +214,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index cb68e612bd35..d3a80cb56892 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -218,6 +218,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index 45ffa2dbe35f..c05f345a40e1 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -226,6 +226,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc >> index a1626d06dfc3..6ba4bd729ae7 100644 >> --- a/OvmfPkg/OvmfXen.dsc >> +++ b/OvmfPkg/OvmfXen.dsc >> @@ -196,6 +196,7 @@ [LibraryClasses] >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.in >> f >> >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variab >> lePolicyHelperLib.inf >> + >> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVar >> iableFlashInfoLib.inf >> >> >> # >> -- >> 2.28.0.windows.1 >> >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#89304): https://edk2.groups.io/g/devel/message/89304 >> Mute This Topic: https://groups.io/mt/90699684/1772286 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] >> -=-=-=-=-=-= >> > > > > >