From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.2288.1600756849849818352 for ; Mon, 21 Sep 2020 23:40:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FQSltwND; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600756849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ufbr1QrJFlMh38MIpYonMGWn5qzsa8iKYnqmKfBw390=; b=FQSltwNDpdA1R5bSnSAJpKmU270avwv9TyhEWMyPNdiSP4ie19jYDnwYmnCgGYm7QUe8Vs BnewgSJeJqdQ3MN65ZLePSg7wtoFKwiiFWGgrwZoH/YsdLfxkPImHh9ZQn5uDuKWvUA73i tkTvVFc2+nThY6LKI4SQ9cb6vseU8YQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-W10-ATIUON6x-tRmVR12PA-1; Tue, 22 Sep 2020 02:40:44 -0400 X-MC-Unique: W10-ATIUON6x-tRmVR12PA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D9D3802B68; Tue, 22 Sep 2020 06:40:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-3.ams2.redhat.com [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id C52255C1D0; Tue, 22 Sep 2020 06:40:38 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v12 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Vladimir Olovyannikov , "Gao, Zhichao" , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" , "Ni, Ray" , Nd , gaoliming References: <20200915180416.8341-1-vladimir.olovyannikov@broadcom.com> <20200915180416.8341-2-vladimir.olovyannikov@broadcom.com> <20e71bc1c6075ddbd280597ac6f61c82@mail.gmail.com> From: "Laszlo Ersek" Message-ID: <3d47afa4-a273-dd4e-3000-484ea691649e@redhat.com> Date: Tue, 22 Sep 2020 08:40:37 +0200 MIME-Version: 1.0 In-Reply-To: <20e71bc1c6075ddbd280597ac6f61c82@mail.gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 09/17/20 18:55, Vladimir Olovyannikov wrote: > Laszlo, what is the outcome? Were you able to run these tests locally? > Is there any step-by-step instruction I can follow? - See my comments at: - https://edk2.groups.io/g/devel/message/64428 - https://edk2.groups.io/g/devel/message/64528 You don't need to go through that entire email; the main points are that I used a separate VM (namely a Fedora 32 Server guest) and in the VM, a python3 virtual environment, for running CI locally. Plus that I had to install some packages manually. - For building ShellPkg, see the Core CI documentation: https://github.com/tianocore/edk2/blob/master/.pytool/Readme.md#running-ci-locally - For building the new dynamic command as part of OVMF, first apply your patches for TianoCore#2857, and then see the Platform CI documentation: https://github.com/tianocore/edk2/tree/master/OvmfPkg/PlatformCI Thanks Laszlo