public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jake Garver" <jake@nvidia.com>
To: <devel@edk2.groups.io>, <jbrasen@nvidia.com>, <ashishsingha@nvidia.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Fix dependency issue in PcdValueInit
Date: Thu, 7 Apr 2022 12:59:03 -0400	[thread overview]
Message-ID: <3d6274d54175807f29a530b181baaa9405667b76.1649350722.git.jake@nvidia.com> (raw)

The generated Makefile was missing a dependency.  This resulted in a
build-time race condition if the recursive make is multi-threaded and
shares job control.

Signed-off-by: Jake Garver <jake@nvidia.com>
---
 BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index fc1e773417..d55ea1bbe2 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -97,7 +97,8 @@ PcdMakefileEnd = '''
 
 AppTarget = '''
 all: $(APPFILE)
-$(APPFILE): $(OBJECTS)
+$(APPLICATION): $(OBJECTS)
+$(APPFILE): $(APPLICATION)
 %s
 '''
 
-- 
2.17.1


             reply	other threads:[~2022-04-07 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 16:59 Jake Garver [this message]
2022-04-25 13:31 ` [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit Jake Garver
2022-05-16 10:35 ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d6274d54175807f29a530b181baaa9405667b76.1649350722.git.jake@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox