* [PATCH] BaseTools: Fix dependency issue in PcdValueInit
@ 2022-04-07 16:59 Jake Garver
2022-04-25 13:31 ` [edk2-devel] " Jake Garver
2022-05-16 10:35 ` Bob Feng
0 siblings, 2 replies; 3+ messages in thread
From: Jake Garver @ 2022-04-07 16:59 UTC (permalink / raw)
To: devel, jbrasen, ashishsingha; +Cc: Jake Garver
The generated Makefile was missing a dependency. This resulted in a
build-time race condition if the recursive make is multi-threaded and
shares job control.
Signed-off-by: Jake Garver <jake@nvidia.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index fc1e773417..d55ea1bbe2 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -97,7 +97,8 @@ PcdMakefileEnd = '''
AppTarget = '''
all: $(APPFILE)
-$(APPFILE): $(OBJECTS)
+$(APPLICATION): $(OBJECTS)
+$(APPFILE): $(APPLICATION)
%s
'''
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit
2022-04-07 16:59 [PATCH] BaseTools: Fix dependency issue in PcdValueInit Jake Garver
@ 2022-04-25 13:31 ` Jake Garver
2022-05-16 10:35 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Jake Garver @ 2022-04-25 13:31 UTC (permalink / raw)
To: Jake Garver, devel
[-- Attachment #1: Type: text/plain, Size: 138 bytes --]
Hello maintainers,
Any interest in accepting this and the "BaseTools/Conf: Fix Dynamic-Library-File template" patch?
Thanks,
Jake
[-- Attachment #2: Type: text/html, Size: 158 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit
2022-04-07 16:59 [PATCH] BaseTools: Fix dependency issue in PcdValueInit Jake Garver
2022-04-25 13:31 ` [edk2-devel] " Jake Garver
@ 2022-05-16 10:35 ` Bob Feng
1 sibling, 0 replies; 3+ messages in thread
From: Bob Feng @ 2022-05-16 10:35 UTC (permalink / raw)
To: devel@edk2.groups.io, jake@nvidia.com, jbrasen@nvidia.com,
ashishsingha@nvidia.com
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jake Garver via groups.io
Sent: Friday, April 8, 2022 12:59 AM
To: devel@edk2.groups.io; jbrasen@nvidia.com; ashishsingha@nvidia.com
Cc: Jake Garver <jake@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Fix dependency issue in PcdValueInit
The generated Makefile was missing a dependency. This resulted in a build-time race condition if the recursive make is multi-threaded and shares job control.
Signed-off-by: Jake Garver <jake@nvidia.com>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py
index fc1e773417..d55ea1bbe2 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -97,7 +97,8 @@ PcdMakefileEnd = '''
AppTarget = '''
all: $(APPFILE)
-$(APPFILE): $(OBJECTS)
+$(APPLICATION): $(OBJECTS)
+$(APPFILE): $(APPLICATION)
%s
'''
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-16 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-07 16:59 [PATCH] BaseTools: Fix dependency issue in PcdValueInit Jake Garver
2022-04-25 13:31 ` [edk2-devel] " Jake Garver
2022-05-16 10:35 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox