From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (NAM04-CO1-obe.outbound.protection.outlook.com [40.107.69.79]) by mx.groups.io with SMTP id smtpd.web10.21266.1594737497164468311 for ; Tue, 14 Jul 2020 07:38:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=m/4s09CD; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.69.79, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XAdHPvuTdF8t+qFQI+CxPV64ma/7IGk9OHtRHSRVJhKikN6q+X9a+ILPOiJyrnE8fxmoVQ2kRZ5zO53Z8zEY+rQhYfPFTnK/VIOFH450KAhN5N+IPRySlHp8Jg1xUH/45PHbz3BrtPBaYsPRHbKNBjFt/mPzWyciejh8MVofaZbaNEt5jlK7mvZCVnpe4XizKTTrGcRiWDhvBya6K2+yvOD/OCB/miO7aKAfzrSV48MRY89QXZmjqleA2kvfQSsw3oX1T/rL4T837w/uD9+a0ipslBK88VGUdJPbNAfXx9/PMDjp6aUk0Dh/W6bZ/ChiwbMhERqpNajKDBdWy0vG6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKE7+qHjsZIcvRUcMZufAvxligKtvF8CIKEGq/A8VMQ=; b=auoqU4kqTA2R2M8fApP+jFKCY2Eg34TJT3arPpqrZyDHg3lBfpGBF/GSAmlqYv7cx5LHGf3TvbEmPOnMlyiGdtVaaNJnYcrY5+zC51NyPMKGvlU38pvshno7MLkSQZuE31SKcQOk8vhnbld3TrWA61RJe+Q9/rUHK/16BrsEqIMaGDP5JxUfwLbunGWvg/aiZEeuct2kj7yoVdoMM4FbJ0o1pkfilGFQBfSzQg5gAGZTn/0obbhCVUIF55JU6DGKtt4eAuOg0XuSUW3HTDA+Sc3C+dSvPFqmjZMa/pLrkP6fyBoGkIs6fzekG/9sCPl9KjbV9EXoLfDVChz66zCr+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKE7+qHjsZIcvRUcMZufAvxligKtvF8CIKEGq/A8VMQ=; b=m/4s09CDDbuNAPPXOf0YXM7oUs0IQe1YUVR8i2ySD4GNF9gMvijHD9TzMEX2FLMUndOi6sTI1x9Q/4zlBGAhC3BI53yZFe7s2TVB5ZTPSDjzODHJUCcDXa68QPw5xuanOr5w8pgNghyyhU07tyXufzAdT0b2hHxxdyqVgVYcYjw= Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB4219.namprd12.prod.outlook.com (2603:10b6:5:217::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 14 Jul 2020 14:38:14 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::25ec:e6ba:197c:4eb0%8]) with mapi id 15.20.3174.026; Tue, 14 Jul 2020 14:38:14 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io CC: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Laszlo Ersek , Liming Gao , Michael D Kinney , Ray Ni Subject: [PATCH v10 32/46] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Tue, 14 Jul 2020 09:37:39 -0500 Message-ID: <3d74eb72b996226fc2faeddbd33506691d5c680a.1594736896.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: X-ClientProxiedBy: DM5PR20CA0032.namprd20.prod.outlook.com (2603:10b6:3:13d::18) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by DM5PR20CA0032.namprd20.prod.outlook.com (2603:10b6:3:13d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 14:38:13 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8449699e-e0f3-4dca-a9df-08d828038a37 X-MS-TrafficTypeDiagnostic: DM6PR12MB4219: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fE02PkcBhYnu+dge3e1dUL70UjJW16RXAz1sdg5s/GowCUYb71Xd4Fz+MJyUPKcqv3TnjTvvZe+aqeGIBVYR42+FEp0UbT1cy1V+uytYKweQrQ/EYAgs9toMylebRz0GhJU2KlnWycHrbxzUkICrvqNY17avEYONzDEei32Su/kJVQxj2ZA+iUp2X4U7DTRB8lzE29xdLvIuIc60TQ92uodzE1cHXCLoKpw3pG/RhOWne3du6bZ3cxpNBPjZc4319xS+5xZXxQ/f2eDruh7q2hb0/TJJNyeX8J2f3iWV5h+Nw6ZlAgE9LGOE7DrDDfZ0/hXrBooNlzNLPK1DWZe6YOgvRm0uHV19QkdYk5ALFXVayiycFfdCH8HNBPw/iNJZUsGH6J926nO6zDFRJTaCLCvGvtzfVJHlVW90rXzKtJnxrdWWHYYuPn+QajEPPCftOHNs8D9ambyJK3zGqqP+ag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(39860400002)(366004)(376002)(396003)(4326008)(316002)(66476007)(2616005)(6916009)(36756003)(2906002)(66556008)(66946007)(54906003)(52116002)(7696005)(6486002)(956004)(8676002)(86362001)(5660300002)(6666004)(186003)(966005)(16526019)(26005)(83380400001)(478600001)(8936002)(136400200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: OW9/Aqmz4EIvcwbxdY3XDGhJks3u2NNroxBJgD+6s9iPag8fgFVksGoqkCHqL9uD1j8fxc9u6kMzURUdWo3prq6S0+XhiAjW/3h+rzwuV14/LZOZacxFLbcI363B9EZ7+J/7dCpy0SnLjJFuGzKYf6c7YDGw0A7EoMvWk5BdGFHA0B+HAAG4ZPk6siR4IhgxZ2NIUoJ7r2hCpBpIyTOmtPdoDN2VNrBe3otEKEGMbmY+tEeM2/RWg3yFCcZY05/VXjd+9si2kGRgh1HfTGwN05WMTJDj1IazIy4bu+LDkZyJsD+XnTNQLmfmktDtxg6d8rUT8Nh//l5qCRqxr9jMGw/NtpaxFTRhM9ibylXklbjoIXT3o2JWHFGxzzXM9D4ECmXtigQhJjxTbCA2URVu8WlYScT1sHsguVhqFe+dxlP2ebojdrjNFaoyPpZaEcYbGCl7GS3+u8sK2srGy7NDUOMqtMv4QtUQBBL/qqEbA6M= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8449699e-e0f3-4dca-a9df-08d828038a37 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2020 14:38:14.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WW6So6xodNie6/V9+cUZvgySvHK1/8DP4baBX7dtHumq1BceKZ1SGDiqTU+zJNqA222kAVQQjuU83kJYSQztBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4219 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 4fd4534cabea..a2b38c591236 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -39,6 +39,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount, PageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; =20 if (!MemEncryptSevEsIsEnabled ()) { return; @@ -83,6 +85,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); =20 AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early G= DT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the= GDT + // will be read as un-encrypted even though it was created before the C-= bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt =3D AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt !=3D NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base =3D (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } =20 /** --=20 2.27.0