From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.10086.1620723062794102428 for ; Tue, 11 May 2021 01:51:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=L7zoCidM; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620723062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oXtHUCjlo7rsWwHXjjBUwR2ZQiizn4m1s+fSUznE3SU=; b=L7zoCidMUqpzprtKPoWmDIiYkeRp28a2vamaxmLVFjx9144j5AO9Bep50/XT0UteotMya0 NJ3eo11IvJOziPLAzuuf1aA2Q7B18/sj6mFXSg09IUxNulyYnnQFEGF1jvhJu/l0fZv4IE OYWTec1JjqPKW6I6K6xGtJ7XN4Ke43Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-GUULJQboNw2Z_RNMALm2Qg-1; Tue, 11 May 2021 04:51:00 -0400 X-MC-Unique: GUULJQboNw2Z_RNMALm2Qg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B02DC801817; Tue, 11 May 2021 08:50:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-233.ams2.redhat.com [10.36.112.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D4A060843; Tue, 11 May 2021 08:50:56 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure To: devel@edk2.groups.io, brijesh.singh@amd.com Cc: James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20210507203838.23706-1-brijesh.singh@amd.com> <20210507203838.23706-5-brijesh.singh@amd.com> From: "Laszlo Ersek" Message-ID: <3d977e06-2941-d020-0f0e-2792ca8359b4@redhat.com> Date: Tue, 11 May 2021 10:50:55 +0200 MIME-Version: 1.0 In-Reply-To: <20210507203838.23706-5-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest is required to perform the GHCB GPA registration. See > the GHCB specification for further details. > > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Reviewed-by: Laszlo Ersek > Signed-off-by: Brijesh Singh > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 7 +++++++ > 1 file changed, 7 insertions(+) Looks OK, thanks! Laszlo > > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Msr.h > index cdb8f588ccf8..542e4cdf4782 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -53,6 +53,11 @@ typedef union { > UINT64 Features:52; > } GhcbHypervisorFeatures; > > + struct { > + UINT64 Function:12; > + UINT64 GuestFrameNumber:52; > + } GhcbGpaRegister; > + > VOID *Ghcb; > > UINT64 GhcbPhysicalAddress; > @@ -62,6 +67,8 @@ typedef union { > #define GHCB_INFO_SEV_INFO_GET 2 > #define GHCB_INFO_CPUID_REQUEST 4 > #define GHCB_INFO_CPUID_RESPONSE 5 > +#define GHCB_INFO_GHCB_GPA_REGISTER_REQUEST 18 > +#define GHCB_INFO_GHCB_GPA_REGISTER_RESPONSE 19 > #define GHCB_HYPERVISOR_FEATURES_REQUEST 128 > #define GHCB_HYPERVISOR_FEATURES_RESPONSE 129 > #define GHCB_INFO_TERMINATE_REQUEST 256 >