Re: [edk2-devel] [PATCH v4 2/3] ShellPkg: acpiview: Add routine to print 16 chars

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Rohit,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 18/08/2023 12:47 pm, Rohit Mathew wrote:
> Certain ACPI tables like MPAM has fields which are 16 bytes long.
> Routines similar to Dump12Chars but for 16 characters are required to
> print such fields. Add Dump16Chars routine to satisfy this requirement.
>
> Signed-off-by: Rohit Mathew <Rohit.Mathew@arm.com>
> Cc: James Morese <james.Morse@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 39 +++++++++++++++++++-
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 18 ++++++++-
>   2 files changed, 55 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index eac9286176..87f55098b8 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -1,7 +1,7 @@
>   /** @file
>     ACPI parser
>   
> -  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> +  Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.
>     Copyright (c) 2022, AMD Incorporated. All rights reserved.
>     SPDX-License-Identifier: BSD-2-Clause-Patent
>   **/
> @@ -449,6 +449,43 @@ Dump12Chars (
>       );
>   }
>   
> +/**
> +  This function traces 16 characters which can be optionally
> +  formated using the format string if specified.
> +
> +  If no format string is specified the Format must be NULL.
> +
> +  @param [in] Format  Optional format string for tracing the data.
> +  @param [in] Ptr     Pointer to the start of the buffer.
> +**/
> +VOID
> +EFIAPI
> +Dump16Chars (
> +  IN CONST CHAR16  *Format OPTIONAL,
> +  IN UINT8         *Ptr
> +  )
> +{
> +  Print (
> +    (Format != NULL) ? Format : L"%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c",
> +    Ptr[0],
> +    Ptr[1],
> +    Ptr[2],
> +    Ptr[3],
> +    Ptr[4],
> +    Ptr[5],
> +    Ptr[6],
> +    Ptr[7],
> +    Ptr[8],
> +    Ptr[9],
> +    Ptr[10],
> +    Ptr[11],
> +    Ptr[12],
> +    Ptr[13],
> +    Ptr[14],
> +    Ptr[15]
> +    );
> +}
> +
>   /**
>     This function indents and prints the ACPI table Field Name.
>   
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> index 4b4397961b..c9f41650d9 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h
> @@ -2,7 +2,7 @@
>     Header file for ACPI parser
>   
>     Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
> -  Copyright (c) 2016 - 2020, Arm Limited. All rights reserved.
> +  Copyright (c) 2016 - 2023, Arm Limited. All rights reserved.
>     Copyright (c) 2022, AMD Incorporated. All rights reserved.
>     SPDX-License-Identifier: BSD-2-Clause-Patent
>   **/
> @@ -202,6 +202,22 @@ Dump12Chars (
>     IN       UINT8   *Ptr
>     );
>   
> +/**
> +  This function traces 16 characters which can be optionally
> +  formated using the format string if specified.
> +
> +  If no format string is specified the Format must be NULL.
> +
> +  @param [in] Format  Optional format string for tracing the data.
> +  @param [in] Ptr     Pointer to the start of the buffer.
> +**/
> +VOID
> +EFIAPI
> +Dump16Chars (
> +  IN CONST CHAR16  *Format OPTIONAL,
> +  IN UINT8         *Ptr
> +  );
> +
>   /**
>     This function indents and prints the ACPI table Field Name.
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107914): https://edk2.groups.io/g/devel/message/107914
Mute This Topic: https://groups.io/mt/100818688/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-