From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E5740AC0D16 for ; Mon, 21 Aug 2023 10:46:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lsrigfsaNB5FEumOjtZJzffv8+RRezNmj1Qnhh+7cLQ=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692614765; v=1; b=ICoOaTfMrczWSoZWslug0aWnT7E7IvZp9ujwYoTqlBL6moeCrZbqXusLH85MSjjhLVWeZqHD TT1+b1IMrha+3nlA6uez1Dx2AIUv1UdBwJkoGQS5QQ13z05UHAJoL3TyXTMlIBpBswvIJju8zmJ kFLacDgZStltLfWmfVYmB5eA= X-Received: by 127.0.0.2 with SMTP id 68NMYY7687511xwhDqqDOHqH; Mon, 21 Aug 2023 03:46:05 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.79]) by mx.groups.io with SMTP id smtpd.web11.8134.1692614764688961240 for ; Mon, 21 Aug 2023 03:46:05 -0700 X-Received: from DUZPR01CA0164.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::18) by DU0PR08MB9321.eurprd08.prod.outlook.com (2603:10a6:10:41c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 10:45:58 +0000 X-Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b3:cafe::6d) by DUZPR01CA0164.outlook.office365.com (2603:10a6:10:4b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20 via Frontend Transport; Mon, 21 Aug 2023 10:45:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6723.11 via Frontend Transport; Mon, 21 Aug 2023 10:45:58 +0000 X-Received: ("Tessian outbound 0b7d6027328f:v175"); Mon, 21 Aug 2023 10:45:58 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6469632b2f0c3060 X-CR-MTA-TID: 64aa7808 X-Received: from 8a2331977b1d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C0D01F6A-0ECD-48C0-A50F-786B22D63141.1; Mon, 21 Aug 2023 10:45:51 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a2331977b1d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Aug 2023 10:45:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEBCoY/Y1SHtrDr4orPklnRQH94JCsjTDfBV1loggUC2YN4WSiYHwm8/ptu+WGh7tL60hntgMcxEXdpgSGLvTAuitE3rUMGYQYNmBydzZ2iEbKwUKjHyxfjo4hjMBQsmkadrbvW5VCk5pcqaep/lITFAY88J/8yAWipepWf1ha47KzlbG+UvC7MD9KL34I4272QavTHv9pBQ5AvBXCGp3CVDZKo++178TtTllVrAzRzEPrn67KpodNrB150bkSeGL+hEUhXoZ7xShb0KUs4DKCJaF6FS1yt+hSc/nHrbmTgTl8lS1/kP5JDzzTX8t1Z5HqBNgmmlFnSRBBwfPbOnuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Hsav2vXljo3hN2dC0MPnc9lCZgBrlhlJ7oIp4ZV1yg=; b=l7ILSzc++4cYR0TQkwtVicZYYhcwQbGSShdBATfIxFw5+1Q/3IgS6kinbUD96RnUwmN7V1S+Dtwkl9S/ytL3Pf3jSVJ4crrxjjIyiXimRm97MERTDJ2teeOMTtmHSun4KJYvpA4FwhXrcVvrkGWxUHVGLb0xU9nvsBOtB0UV4+JbnT6i/fdlOvUoNZRnN3B97+KID1D9KGv+L+IvlIMmJLE/O/IPS4VjbCDfpAeBTFGyeyhDJvQWZ0IEa/Uc5Wmw0IYFPOWdjca8xEkibvEpKxec910/DbmyHey6/0w/U0rnXhlYhjGkQQFmLYbYhklM7Do3Rxz7qE60XsBs7WiG8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS2PR08MB8927.eurprd08.prod.outlook.com (2603:10a6:20b:5fa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 10:45:50 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ac37:4594:ab86:59ce%4]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 10:45:50 +0000 Message-ID: <3d9a849a-1ef1-f419-4fd6-61ab42630035@arm.com> Date: Mon, 21 Aug 2023 11:45:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [edk2-devel] [PATCH v4 2/3] ShellPkg: acpiview: Add routine to print 16 chars To: Rohit Mathew , devel@edk2.groups.io Cc: Thomas Abraham , James Morse , Zhichao Gao , Pierre Gondois , "nd@arm.com" References: <20230818114722.474762-1-Rohit.Mathew@arm.com> From: "Sami Mujawar" In-Reply-To: <20230818114722.474762-1-Rohit.Mathew@arm.com> X-ClientProxiedBy: LO4P265CA0003.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::6) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|AS2PR08MB8927:EE_|DBAEUR03FT023:EE_|DU0PR08MB9321:EE_ X-MS-Office365-Filtering-Correlation-Id: d6e0d913-be56-4856-9046-08dba233ce04 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: l2XsXq9Z3x5+imuqKKTJdyTUFj6J+281rGslqvjwtqW4Gr29huN7bnF/849D8GHQnW4RZG6YJuf/8XUSFS7LBSjPQSP9nrdA1xHm4nx8b5Xq7thQGNasGfbsYBW+ymP/2ap6gW/3K+eL+Prud+OCfVIoLURvw6K1WiejNvPndOv3zkkphkzZrP9+ZnSY2OjfygrZpalfklAR+eGi7ku3SSAtM4Jo6co3niSktI5eB8uq4HJO4oxefmU/f7srUCZtEIcR4NlS7+yjxyHqc8yxy5uI4T6kqGej7MtyiWCz9xoHvij9WwUG1a0WjBZXGklCmCMg+rTTH+Qc3WuhQiIbMupxik7PyzpLJS72gziacaLsep9x26XitnCreXT3Pw218/qe1lX6wOlXKmxI6VteejXtBgI4EmEGH5WysVDBIoh2wEpTiuw9Hh5jTd7tNnRMDD5fdbuD5h/kjAn0xhhXuPcb2qo5Qh7d/IoA67rf36JCFXbDGOfY3c1HlgvXejgZy6zrTfHR7GTzfbXx/oRIKiBpyniXNmrftQq5WbQRDXX/eD7nQRRS/ogUS9zpzOvUUDG8fiSDaSXXIezQMyBOaG9nydFTuIP5uYOJOFRBAqpu4NgLw/N3C07El6rr5fznQoj/fQ3HvbpCWUjFHO+XKA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199024)(186009)(1800799009)(2906002)(83380400001)(53546011)(38100700002)(6506007)(6486002)(5660300002)(44832011)(26005)(86362001)(31686004)(31696002)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(66556008)(66476007)(478600001)(41300700001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8927 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 544d8a7d-ef4f-4fe3-c267-08dba233c8e9 X-Microsoft-Antispam-Message-Info: E+pL1Of2OSWA3IdN4eHspepOEXflO+fty51cO+9tuak60rtWsUJ6Cc/UytPqb9iDBMTswqLeOV7M6sFcvpfLyv4MwM/6EbLCMC+URLBKn5tu56s6ARwlMr84cNce9iIrL2Ev8LcnQVR+Dw7bAF8aSm5HX/iRZC0vyfcwXEU32MdQGvSRpTSRIT7PCKD7Dtbzx+j8XT8ivESV8ysGG+fZ5TS8+VNbwdZQFR0DRJUeY0w5718oTOBM5incGbKRQ5tWfaPQzRzhyThyaQcG2W6Zo8lsQJ1wHZjEthisJzwxHk+/KolGIOyg1+0WHpR4p1TQnbyEltbPk8u0MyiXjy8mmLinW7csQmBUZhz0RswD/TuB/ePldINFgCFEMheyXYy8B5XpYD1p+IYkuB1cgbEITX1iQP+gYIW1I5oC/J9N26HAEC40IV0pgr7J1X9/P+hHFkFWxRDvGbnRnhd6+xN2h5+VWZiEdW7U11rQ5IBA+UGS/8FFhyavgI9IvBLuwuvm9YZifkW3axtO1Lgctb8AAxGCIp2oRKLKLGMJo7rDkpGZtsSXti/I2FAmBY7kk2fqXZNPhT8EnYfxsEUyMDysUDYSeu2YzAfcmKyMGu91Iso4OJhg3a8nxHYtzNdKhuG7UfnTWpX46INJ8ia0Ni7BosLiXNuvN2z4wFbR7p8z8wI9sgVx/SGjjnB0N3WrCbpRj0Y2QUYRAPTbimLlotZ4N+B58JlNTJDsorwxC/ikJudh5tyjwixtM9dnJZiZiazGjoTKe/GVS+jdZcG1kD8AIA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 10:45:58.6494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6e0d913-be56-4856-9046-08dba233ce04 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9321 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: z8nNdL4A9UXsHu6cTnDnCDwkx7686176AA= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ICoOaTfM; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Rohit, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 18/08/2023 12:47 pm, Rohit Mathew wrote: > Certain ACPI tables like MPAM has fields which are 16 bytes long. > Routines similar to Dump12Chars but for 16 characters are required to > print such fields. Add Dump16Chars routine to satisfy this requirement. > > Signed-off-by: Rohit Mathew > Cc: James Morese > Cc: Sami Mujawar > Cc: Thomas Abraham > Cc: Zhichao Gao > Reviewed-by: Pierre Gondois > Reviewed-by: Zhichao Gao > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 39 ++++++++= +++++++++++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 18 ++++++++= - > 2 files changed, 55 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/= ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > index eac9286176..87f55098b8 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > @@ -1,7 +1,7 @@ > /** @file > ACPI parser > =20 > - Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > + Copyright (c) 2016 - 2023, Arm Limited. All rights reserved. > Copyright (c) 2022, AMD Incorporated. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -449,6 +449,43 @@ Dump12Chars ( > ); > } > =20 > +/** > + This function traces 16 characters which can be optionally > + formated using the format string if specified. > + > + If no format string is specified the Format must be NULL. > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > +**/ > +VOID > +EFIAPI > +Dump16Chars ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr > + ) > +{ > + Print ( > + (Format !=3D NULL) ? Format : L"%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c", > + Ptr[0], > + Ptr[1], > + Ptr[2], > + Ptr[3], > + Ptr[4], > + Ptr[5], > + Ptr[6], > + Ptr[7], > + Ptr[8], > + Ptr[9], > + Ptr[10], > + Ptr[11], > + Ptr[12], > + Ptr[13], > + Ptr[14], > + Ptr[15] > + ); > +} > + > /** > This function indents and prints the ACPI table Field Name. > =20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/= ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > index 4b4397961b..c9f41650d9 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > @@ -2,7 +2,7 @@ > Header file for ACPI parser > =20 > Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved. > - Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. > + Copyright (c) 2016 - 2023, Arm Limited. All rights reserved. > Copyright (c) 2022, AMD Incorporated. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -202,6 +202,22 @@ Dump12Chars ( > IN UINT8 *Ptr > ); > =20 > +/** > + This function traces 16 characters which can be optionally > + formated using the format string if specified. > + > + If no format string is specified the Format must be NULL. > + > + @param [in] Format Optional format string for tracing the data. > + @param [in] Ptr Pointer to the start of the buffer. > +**/ > +VOID > +EFIAPI > +Dump16Chars ( > + IN CONST CHAR16 *Format OPTIONAL, > + IN UINT8 *Ptr > + ); > + > /** > This function indents and prints the ACPI table Field Name. > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107914): https://edk2.groups.io/g/devel/message/107914 Mute This Topic: https://groups.io/mt/100818688/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-