From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA3072095606A for ; Wed, 14 Mar 2018 22:22:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 22:28:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,308,1517904000"; d="scan'208";a="24671979" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2018 22:28:40 -0700 To: Jian J Wang , edk2-devel@lists.01.org References: <20180315050326.17440-1-jian.j.wang@intel.com> From: "Ni, Ruiyu" Message-ID: <3d9fa852-f62e-fe0e-3c2d-049517343e14@Intel.com> Date: Thu, 15 Mar 2018 13:28:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180315050326.17440-1-jian.j.wang@intel.com> Subject: Re: [PATCH v3 0/3] fix empty window period of HeapGuard before CpuArchProtocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 05:22:18 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/15/2018 1:03 PM, Jian J Wang wrote: >> v3: >> Split the fixes into three patch files. > >> v2: >> Fix a logic hole in bits operation on address on 64K boundary with >> just 64-bit length (SetBits(), ClearBits(), GetBits()). > > This patch series fills up an empty window period of HeapGuard feature > before CpuArchProtocol installed, and fix an issue observed on 32-bit > real platform with this HeapGuard fix. > > Jian J Wang (3): > MdeModulePkg/Core: allow HeapGuard even before CpuArchProtocol > installed > MdeModulePkg/PiSmmCore: fix bits operation error on a boundary > condition > MdeModulePkg/Core: fix bits operation error on a boundary condition > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 10 ++ > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 148 ++++++++++++++++++++++++-- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 8 ++ > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 5 + > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 16 +-- > 5 files changed, 174 insertions(+), 13 deletions(-) > Reviewed-by: Ruiyu Ni -- Thanks, Ray