From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F8587803E1 for ; Wed, 18 Oct 2023 13:44:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YVczjm3uLy8/KdYtaBKw46dW0oS+HcgtgXdvJCVvRbc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697636690; v=1; b=MrG5XCZT0u72dr8bH4zJMsiOt40KEmf19awP9Q13V23+udsDMDm9npXo+CvAvDlV8takrySu +mCLH+XR0mFUvqeoliwB3yRkK03GfFm8tBvlQDnMsv8dHWgAOwNQ6Wv8MN7jZJs9rn+ZBDnzsKE zPxLRwjNas42mV2aCJBPdwmg= X-Received: by 127.0.0.2 with SMTP id gSPpYY7687511xD7Pb8mhshY; Wed, 18 Oct 2023 06:44:50 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.281992.1697636689652015623 for ; Wed, 18 Oct 2023 06:44:49 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-245-lLK5tK5bNcKYneGutGjcIg-1; Wed, 18 Oct 2023 09:44:43 -0400 X-MC-Unique: lLK5tK5bNcKYneGutGjcIg-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 218F428AC1F1; Wed, 18 Oct 2023 13:44:43 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BAF8492BFC; Wed, 18 Oct 2023 13:44:41 +0000 (UTC) Message-ID: <3de679e1-a11f-b336-7023-994f8621ef32@redhat.com> Date: Wed, 18 Oct 2023 15:44:40 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document. To: Sunil V L , devel@edk2.groups.io Cc: =?UTF-8?B?6JSh6Zuo5pm0?= , USER0FISH , Leif Lindholm , Michael D Kinney , Inochi Amaoto , Ard Biesheuvel References: <022a1dd866233cd1d2ae518f91720487f7569b34.1697120122.git.caiyuqing_hz@outlook.com> <67438e36.2d9.18b428542db.Coremail.caiyuqing_hz@163.com> <093ea77b-ae2a-8ffb-5646-9c1ddea87575@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lGomhpl29jNCAb5NPDMzrBttx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MrG5XCZT; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/18/23 14:21, Sunil V L wrote: > On Wed, Oct 18, 2023 at 02:11:17PM +0200, Laszlo Ersek wrote: >> On 10/18/23 13:21, 蔡雨晴 wrote: >>> Hi Laszlo, >>> >>> Thank you for your comments. I will commit a new patch to add the >>> maintainers to the "Maintainers.txt" file in the root directory of the >>> edk2-platforms project. >>> >>> Please let us know if you have more suggestions. >> >> I do have one, but it's not specifically for this patch set, but for all >> future edk2(-platforms) patches you may post -- please add "--stat=1000 >> --stat-graph-width=20" to your git-format-patch command line. >> Edk2(-platforms) use(s) long pathnames, and so the cumulative diffstat >> tends to be truncated, and on the left side at that. That fact makes it >> hard to see the extent of a patchset. If you add these options, then the >> cumulative diffstat is going to be just as wide as it needs to be -- no >> truncation, and no needless padding. >> >> The "BaseTools/Scripts/SetupGit.py" utility creates a git-format-patch >> alias called "fp" that includes these options. >> >> BTW I could help Ard out by pushing this patch set (well, v4, with the >> Maintainers.txt fix), I'm just not clear when a patch set counts as >> "sufficiently reviewed" for edk2-platforms. >> >> Laszlo >> > Hi Laszlo, > > I have pushed the v5 series since they looked decent. Sure, thanks -- it's useful if the person merging the series confirms that fact on-list at once (when the merge request is successfully closed). > Leif had given > some feedback which are taken care and they looked decent. Maintainer > entry needs to be added as separate patch. I know there are further > improvements planned. > > BTW, I have recommended many people to read your guide [1] which I also > refer every time. Though few things like Setup.py can be added, I found > your document is really good for any one working on EDK2 patches. > Thanks! > > [1] - > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers Glad to hear that! Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109753): https://edk2.groups.io/g/devel/message/109753 Mute This Topic: https://groups.io/mt/101944473/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-