From: "David Woodhouse" <dwmw2@infradead.org>
To: devel@edk2.groups.io, lersek@redhat.com, jljusten@gmail.com,
afish@apple.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable
Date: Thu, 20 Jun 2019 18:32:16 +0100 [thread overview]
Message-ID: <3def810039016f9b48deff0526720136a996a7b3.camel@infradead.org> (raw)
In-Reply-To: <29111f7d-0f4c-bba6-697d-c061ce1b6488@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote:
> If it's possible, please write a non-empty commit message body, for each
> patch in this series. Just one sentence on this patch would be nice.
The comnit comment isn't empty. It has one sentence "LegacyBios: set
NumberBbsEntries to the size of BbsTable".
A second sentence would be redundant and render the description larger
than the patch itself. I can't think of anything useful I'd want to put
in it. Apparently neither could you when you posted the same patch in
2013 after splitting it out from a larger patch of mine. :)
https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01618.html
> I think your note on patch#2 is valuable too and should be captured in
> the commit message body. Please consider formulating it with a bit more
> neutral tone :)
I would prefer to express that particular concern in 'diff -up' form
when actually fixing it :)
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]
next prev parent reply other threads:[~2019-06-20 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359122038.24865.19.camel@shinybook.infradead.org>
[not found] ` <1359147866-15605-3-git-send-email-lersek@redhat.com>
2019-06-18 9:13 ` [PATCH 2/2] LegacyBbs: add boot entries for virtio-blk devices David Woodhouse
2019-06-19 12:44 ` [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable David Woodhouse
2019-06-20 16:12 ` [edk2-devel] " Laszlo Ersek
2019-06-20 17:32 ` David Woodhouse [this message]
2019-06-20 20:35 ` Laszlo Ersek
2019-06-21 10:59 ` David Woodhouse
2019-06-24 22:08 ` Laszlo Ersek
2019-06-24 22:22 ` Laszlo Ersek
[not found] ` <F95F0A95-4638-4B08-BDAF-53A797A6B877@infradead.org>
2019-06-25 7:06 ` Ni, Ray
2019-06-25 10:34 ` Laszlo Ersek
2019-06-25 7:29 ` David Woodhouse
2019-06-24 11:48 ` David Woodhouse
2019-06-24 21:49 ` Laszlo Ersek
2019-06-19 12:44 ` [PATCH 2/2] LegacyBbs: Add boot entries for VirtIO and NVME devices David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3def810039016f9b48deff0526720136a996a7b3.camel@infradead.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox