Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

["Laszlo Ersek" <lersek@redhat.com>]

On 08/09/19 03:37, Feng, Bob C wrote:
> Thanks for your response.
> 
> I'm going to push this patch set late today, if there is no more comments.

Sorry, I have to disagree about that. There is a NACK standing from Leif
-- he will have to rescind that NACK explicitly, for you to push the series.

Leif: can you please confirm, in light of the new information [*] if you
are OK with this v8 patchset being merged?

[*] The new information is that "--hash" breaks "pick-up" after Ctrl-C,
independently of the present patchset. So, it's not a regression from
the new work, and if "--hash" is removed from the command line, the
"pick-up" is successful both with and without these patches.

Thanks!
Laszlo



> -----Original Message-----
> From: Gao, Liming 
> Sent: Friday, August 9, 2019 8:50 AM
> To: devel@edk2.groups.io; lersek@redhat.com; Feng, Bob C <bob.c.feng@intel.com>; leif.lindholm@linaro.org
> Cc: Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen
> 
> Bob:
>   I have no comments for this patch set. I am OK to add it for 201908 stable tag. 
>   
>   Ack-by: Liming Gao <liming.gao@intel.com>
> 
> Thanks
> Liming
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of 
>> Laszlo Ersek
>> Sent: Friday, August 9, 2019 7:29 AM
>> To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io; 
>> leif.lindholm@linaro.org
>> Cc: Andrew Fish <afish@apple.com>; Kinney, Michael D 
>> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
>> Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process 
>> AutoGen
>>
>> On 08/09/19 00:18, Laszlo Ersek wrote:
>>> On 08/08/19 17:38, Feng, Bob C wrote:
>>>> Hi Laszlo and Leif,
>>>>
>>>> Thanks for you detailed testing and comments.
>>>>
>>>> I'd like to explain the failure of the test 3#. I can reproduce the 
>>>> failure with your steps and I found this failure can also be 
>>>> reproduced
>> without multiple process autogen patch set.  I debugged and found this 
>> failure is due to --hash build option. I double tested that if remove --hash build option, the test 3# can pass.  Would you please double verified test 3# without --hash?
>>>>
>>>> I think we can enter a new BZ for the --hash bug.
>>>
>>> Confirmed -- with "--hash" removed from the build command line, the 
>>> build is picked up fine after Ctrl-C. (And the firmware binary is
>> sound.)
>>>
>>> So, my ACK stands.
>>>
>>> (
>>>
>>> And now I remember that in my v3 testing, I also omitted "--hash":
>>>
>>>   http://mid.mail-archive.com/4ea3d3fa-2210-3642-2337-db525312d312@redhat.com
>>>   https://edk2.groups.io/g/devel/message/44246
>>>
>>> At the bottom I stated that I didn't test "--hash".
>>>
>>> )
>>
>> ... based on the above, I can even provide:
>>
>> Tested-by: Laszlo Ersek <lersek@redhat.com>
>>
>> for the series.
>>
>> Thanks
>> Laszlo
>>
>> 
>