From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 09 Aug 2019 05:54:35 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8267881DE0; Fri, 9 Aug 2019 12:54:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-119.ams2.redhat.com [10.36.117.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDB0117B5A; Fri, 9 Aug 2019 12:54:32 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen To: "Feng, Bob C" , "Gao, Liming" , "devel@edk2.groups.io" , "leif.lindholm@linaro.org" Cc: Andrew Fish , "Kinney, Michael D" References: <20190807042537.11928-1-bob.c.feng@intel.com> <20190808134522.GY25813@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D160B559E9@SHSMSX105.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4CD287@SHSMSX104.ccr.corp.intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16150242B@SHSMSX105.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <3df03b87-1b32-0647-ca68-54508df8aae0@redhat.com> Date: Fri, 9 Aug 2019 14:54:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16150242B@SHSMSX105.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 09 Aug 2019 12:54:34 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/09/19 03:37, Feng, Bob C wrote: > Thanks for your response. > > I'm going to push this patch set late today, if there is no more comments. Sorry, I have to disagree about that. There is a NACK standing from Leif -- he will have to rescind that NACK explicitly, for you to push the series. Leif: can you please confirm, in light of the new information [*] if you are OK with this v8 patchset being merged? [*] The new information is that "--hash" breaks "pick-up" after Ctrl-C, independently of the present patchset. So, it's not a regression from the new work, and if "--hash" is removed from the command line, the "pick-up" is successful both with and without these patches. Thanks! Laszlo > -----Original Message----- > From: Gao, Liming > Sent: Friday, August 9, 2019 8:50 AM > To: devel@edk2.groups.io; lersek@redhat.com; Feng, Bob C ; leif.lindholm@linaro.org > Cc: Andrew Fish ; Kinney, Michael D > Subject: RE: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen > > Bob: > I have no comments for this patch set. I am OK to add it for 201908 stable tag. > > Ack-by: Liming Gao > > Thanks > Liming >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Friday, August 9, 2019 7:29 AM >> To: Feng, Bob C ; devel@edk2.groups.io; >> leif.lindholm@linaro.org >> Cc: Andrew Fish ; Kinney, Michael D >> ; Gao, Liming >> Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process >> AutoGen >> >> On 08/09/19 00:18, Laszlo Ersek wrote: >>> On 08/08/19 17:38, Feng, Bob C wrote: >>>> Hi Laszlo and Leif, >>>> >>>> Thanks for you detailed testing and comments. >>>> >>>> I'd like to explain the failure of the test 3#. I can reproduce the >>>> failure with your steps and I found this failure can also be >>>> reproduced >> without multiple process autogen patch set. I debugged and found this >> failure is due to --hash build option. I double tested that if remove --hash build option, the test 3# can pass. Would you please double verified test 3# without --hash? >>>> >>>> I think we can enter a new BZ for the --hash bug. >>> >>> Confirmed -- with "--hash" removed from the build command line, the >>> build is picked up fine after Ctrl-C. (And the firmware binary is >> sound.) >>> >>> So, my ACK stands. >>> >>> ( >>> >>> And now I remember that in my v3 testing, I also omitted "--hash": >>> >>> http://mid.mail-archive.com/4ea3d3fa-2210-3642-2337-db525312d312@redhat.com >>> https://edk2.groups.io/g/devel/message/44246 >>> >>> At the bottom I stated that I didn't test "--hash". >>> >>> ) >> >> ... based on the above, I can even provide: >> >> Tested-by: Laszlo Ersek >> >> for the series. >> >> Thanks >> Laszlo >> >> >