From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, rebecca@nuviainc.com
Cc: Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings.
Date: Mon, 4 Jan 2021 11:40:25 +0100 [thread overview]
Message-ID: <3df6139b-6cec-8491-3e8d-d5869ceab6ad@redhat.com> (raw)
In-Reply-To: <20201228231637.17266-2-rebecca@nuviainc.com>
On 12/29/20 12:16 AM, Rebecca Cran wrote:
> Neither of the "CPU Socket Unpopulated" or "Do not reboot" messages
> should contain the word "Bits".
>
> Remove them and update the identifier for the "Do not reboot" message
> to remove the word "BITS".
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +-
> ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
prev parent reply other threads:[~2021-01-04 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 23:16 [PATCH 0/1] ShellPkg: Remove the word "Bits" from a couple of smbiosview strings Rebecca Cran
2020-12-28 23:16 ` [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some " Rebecca Cran
2020-12-31 0:23 ` Gao, Zhichao
2021-01-04 10:40 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df6139b-6cec-8491-3e8d-d5869ceab6ad@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox