From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web10.41041.1683402306915924873 for ; Sat, 06 May 2023 12:45:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=bCJpnRhL; spf=pass (domain: bsdio.com, ip: 64.147.123.24, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9733E320092B; Sat, 6 May 2023 15:45:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 06 May 2023 15:45:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:sender:subject:subject:to:to; s= fm1; t=1683402305; x=1683488705; bh=33ChGI0Rj5Vy0LVwg05e70DUld/E 8v+jWmxUJxN/8jw=; b=bCJpnRhLmqX9+o5Hy8pW+GjRkCcGyC2NlzmhcXWxG1U1 CDreuewkdD3rzKqjxX54Kr9ltGMAZkWsYmWKmjct1jL+4ilzTXqU3wsIx5214SKR 4u4kEtQrWh7F3VFCCP5fFeNTjzBC3oOTp++egaIpANk4afGSYmd1wm1UrMWehgWA 3A94M6rGCXEVwRS+rMrIuyaS/gPhk9mgrQGDLYTJ0cQQvEBj3F0aPQa1Rp4UbpM2 LYNFbF2+g3pcMBJ8p7Xa5k+7eTcKJMMgMcWqx8QJptgGgBQkWmbJlAznikTOmowi n8ERDfAcaFQPbDQ2cHQ6ZAjOTaSk2jxGX0u/JLi71A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1683402305; x=1683488705; bh=33ChGI0Rj5Vy0LVwg05e70DUld/E 8v+jWmxUJxN/8jw=; b=XtSRthUJ13ZrjroznENH+f/I0pKLxbjJxKUy3E3fHhVr xzFqQZYg+5dVuUKvr9tkn3W/Nzf6ijcPbTBOW97YU8IqeHcTZbRgkihGdc3hbEEZ wdPb5xpO505zhfrlOWiIVprkGL5gDt7k681QWks7Xek1YWNhWa3f6uVe7qoi51nx bmz/LrzdIM60obfFf28Zhpp7RlT0pJfQAnkuKCFEe1KRTE+p7oyojrJOBEsHl0bO +1AhNRZYdLDU3VG1VKex1riZekhvb0CrquSscJ24RlSttV83TPNudTvvqrTPSxHF vB0MXp3nqJ1DsjTjJU6o1QdO3dblIz8i/ss9kZlp0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuhffvvehrfhgjtgfgsehtjeertddtfeejnecuhfhrohhmpeft vggsvggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtf frrghtthgvrhhnpeeifefgvdfhuefhhefhieeludegjeffteetveelgeeuueelieevteel vefgledtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 May 2023 15:45:03 -0400 (EDT) Message-ID: <3e01cc9e-ac5f-bf4d-0359-adfc1aa21c4b@bsdio.com> Date: Sat, 6 May 2023 13:45:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [PATCH 1/1] Remove bashisms from edksetup.sh and BaseTools/BuildEnv From: "Rebecca Cran" To: devel@edk2.groups.io, pedro.falcato@gmail.com Cc: Liming Gao , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Michael D Kinney Reply-To: devel@edk2.groups.io, rebecca@bsdio.com References: <20230506182311.14023-1-rebecca@bsdio.com> <175CA4E73380D66F.2502@groups.io> In-Reply-To: <175CA4E73380D66F.2502@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Actually, the python package provides a python command, and python3 provides a python3 command, both of which are Python 3.9.16. So I no longer need to specify PYTHON_COMMAND. bcran@maxamd:~/src/uefi/edk2 % /bin/sh $ . edksetup.sh Loading previous configuration from /home/bcran/src/uefi/edk2/Conf/BuildEnv.sh Using EDK2 in-source Basetools WORKSPACE: /home/bcran/src/uefi/edk2 EDK_TOOLS_PATH: /home/bcran/src/uefi/edk2/BaseTools CONF_PATH: /home/bcran/src/uefi/edk2/Conf $ echo $PYTHON_COMMAND python3 $ python3 --version Python 3.9.16 -- Rebecca Cran On 5/6/23 13:34, Rebecca Cran wrote: > On 5/6/23 12:34, Pedro Falcato wrote: >> Did you test this in FreeBSD (and hopefully other BSDs, such as Net)? >> As far as I know, those don't package a python3 symlink (only >> python3.{version}). >> >> At a glance, the rest of the changes look ok-ish to me though. > > I only tested on FreeBSD, where the behavior is the same as before: I > still need to specify PYTHON_COMMAND=python3.9 . > >