From: "Laszlo Ersek" <lersek@redhat.com>
To: Marc W Chen <marc.w.chen@intel.com>, devel@edk2.groups.io
Cc: "Jordan Justen" <jordan.l.justen@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Julien Grall" <julien.grall@arm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.
Date: Wed, 5 Jun 2019 19:15:25 +0200 [thread overview]
Message-ID: <3e1e6d19-2c69-e095-148c-99b2ce31a36c@redhat.com> (raw)
In-Reply-To: <b0027d3c-8812-7b3d-0749-4a6442ac6fa0@redhat.com>
On 06/05/19 14:00, Laszlo Ersek wrote:
> On 06/05/19 13:14, Marc W Chen wrote:
>> Query the supported attributes firstly, then AND (&&) both
>> VGA_IO and VGA_IO_16.
>
> I don't think you mean "logical AND" above.
On second thought, you do mean "logical AND" above, it's just that the
wording is a bit difficult to understand (to me anyway). So please
ignore this part of my review (but please answer the rest of the questions).
Thanks
Laszlo
next prev parent reply other threads:[~2019-06-05 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 11:14 [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode Marc W Chen
2019-06-05 12:00 ` Laszlo Ersek
2019-06-05 17:15 ` Laszlo Ersek [this message]
2019-06-06 4:18 ` [edk2-devel] " Marc W Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e1e6d19-2c69-e095-148c-99b2ce31a36c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox