From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 05 Jun 2019 10:16:01 -0700
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 17923223882;
	Wed,  5 Jun 2019 17:15:33 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-187.ams2.redhat.com [10.36.116.187])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D4B1E4D1;
	Wed,  5 Jun 2019 17:15:26 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.
From: "Laszlo Ersek" <lersek@redhat.com>
To: Marc W Chen <marc.w.chen@intel.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 Julien Grall <julien.grall@arm.com>,
 =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@redhat.com>,
 Stefan Berger <stefanb@linux.ibm.com>
Reply-To: devel@edk2.groups.io, lersek@redhat.com
References: <20190605111410.73564-1-marc.w.chen@intel.com>
 <b0027d3c-8812-7b3d-0749-4a6442ac6fa0@redhat.com>
Message-ID: <3e1e6d19-2c69-e095-148c-99b2ce31a36c@redhat.com>
Date: Wed, 5 Jun 2019 19:15:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <b0027d3c-8812-7b3d-0749-4a6442ac6fa0@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 05 Jun 2019 17:15:49 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/05/19 14:00, Laszlo Ersek wrote:
> On 06/05/19 13:14, Marc W Chen wrote:
>> Query the supported attributes firstly, then AND (&&) both
>> VGA_IO and VGA_IO_16.
> 
> I don't think you mean "logical AND" above.

On second thought, you do mean "logical AND" above, it's just that the
wording is a bit difficult to understand (to me anyway). So please
ignore this part of my review (but please answer the rest of the questions).

Thanks
Laszlo