From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.175.1589226487006352780 for ; Mon, 11 May 2020 12:48:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JdmYOC6D; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589226486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EKK8uIFWL32sP56sdjX1zmOGar8KsCeXyrrY+BSB3NU=; b=JdmYOC6DC7nP9ojL9X4Har4mrHyaP/EASl7t/lqx6GjsTzuOZCM/5yZBe5M3shcUaaxBFA HGX4Ji9HDIV4rte+4xLDlrkfG05HhDxh6527K3PDgZlVo4PLvn0UBF0+DYIDtiKTavH98H Q9fKfYhsah5MZ99CYXciN3xlZ/yaw+4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-6MkPAGwJO8mMHgWKIm7NGg-1; Mon, 11 May 2020 15:47:54 -0400 X-MC-Unique: 6MkPAGwJO8mMHgWKIm7NGg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E3D71895A57; Mon, 11 May 2020 19:47:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-11.ams2.redhat.com [10.36.113.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BC2060BF1; Mon, 11 May 2020 19:47:52 +0000 (UTC) Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process To: devel@edk2.groups.io, ray.ni@intel.com, "rfc@edk2.groups.io" , "Kinney, Michael D" References: <734D49CCEBEEF84792F5B80ED585239D5C530C37@SHSMSX104.ccr.corp.intel.com> Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= From: "Laszlo Ersek" Message-ID: <3e353474-0408-342a-b5f1-fe85c6dc8b98@redhat.com> Date: Mon, 11 May 2020 21:47:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C530C37@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/09/20 06:22, Ni, Ray wrote: > Mike, > It's a huge improvement to me as an Outlook user if pull-request-based review is enabled! > > Please help me to understand: The pull-request-based review has been enabled naturally when edk2 > was migrated to Github. People don't use it because it's not accepted by community. Your process > tries to meet community's needs of achieving all review comments in mails so pull-request-based > review can be accepted by community. Right? > > I just subscribed at https://www.redhat.com/mailman/listinfo/tianocore-code-review-poc with > empty password. > I received the confirmation mail and clicked the link in the mail to confirm. > But I waited for ~15 minutes and didn't receive the additional mail containing the auto-generated password. That's because the proof-of-concept list is currently subscriber-only, and subscription requests have to be manually approved -- by Phil, or by me. The PoC list contains a bunch of webhook test messages, and while they are not secret, they are not useful to the grand public (and arguably shouldn't be indexed by web search engines either). Once we go live, the intent is that production list be publicly visible. (Of course spam could become a problem; we'll see.) Importantly, I totally don't "insist" that the email archive be hosted on redhat.com (in fact it's extra moderation work for me, which I don't necessarily welcome); I just offered because Red Hat associates can request such public-facing mailing lists if they support relevant open source development efforts. The traffic should be federated to multiple lists, preferably, and the redhat.com-hosted list need not be the primary archive address. Wherever the primary list will live, we can subscribe the mail-archive.com daemon to it, too. > I went to https://www.redhat.com/mailman/private/tianocore-code-review-poc/2020-May/thread.html#00289. > However, the page requires me to enter password. > Can you please change the setting so that viewing the mail achieve doesn't need password? The password protection should remain in place for now, I think. I've approved your subscription request; sorry about the delay. (I avoid reading work email on the weekend.) Thanks! Laszlo