From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B1CE81EC8 for ; Thu, 17 Nov 2016 08:01:14 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FF061ACD13; Thu, 17 Nov 2016 16:01:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-6.phx2.redhat.com [10.3.116.6]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAHG1Hce001808; Thu, 17 Nov 2016 11:01:18 -0500 To: "Mudusuru, Giri P" , edk2-devel-01 References: <20161117103649.15110-1-lersek@redhat.com> <4666AEFED60F8E4198B42BB01DCEABDF76F5B3DD@ORSMSX113.amr.corp.intel.com> Cc: "Yao, Jiewen" From: Laszlo Ersek Message-ID: <3e4aa301-e38c-65ba-80e2-200db93b2563@redhat.com> Date: Thu, 17 Nov 2016 17:01:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4666AEFED60F8E4198B42BB01DCEABDF76F5B3DD@ORSMSX113.amr.corp.intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 17 Nov 2016 16:01:19 +0000 (UTC) Subject: Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 16:01:14 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/17/16 15:27, Mudusuru, Giri P wrote: > Thank you for fixing it. > Reviewed-by: Giri P Mudusuru Thanks! I was eager and already committed it with Jiewen's R-b. Cheers! Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Thursday, November 17, 2016 2:37 AM >> To: edk2-devel-01 >> Cc: Mudusuru, Giri P ; Yao, Jiewen >> >> Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from >> GUID def >> >> The DEC spec doesn't allow the trailing semicolon: >> >> 2.6 [Guids] Usage >> >> GuidCName = {C Format Guid Value} # Comment >> >> Cc: Giri P Mudusuru >> Cc: Jiewen Yao >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> IntelSiliconPkg/IntelSiliconPkg.dec | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec >> b/IntelSiliconPkg/IntelSiliconPkg.dec >> index 4a51d0a547da..8819cb8fed6b 100644 >> --- a/IntelSiliconPkg/IntelSiliconPkg.dec >> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec >> @@ -26,7 +26,7 @@ [Includes] >> [Guids] >> ## GUID for Package token space >> # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735} >> - gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad, >> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }; >> + gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad, >> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } } >> >> ## HOB GUID to publish SMBIOS data records from PEI phase >> # HOB data format is same as SMBIOS records defined in SMBIOS spec or OEM >> defined types >> -- >> 2.9.2 >