From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.9609.1574101974228006736 for ; Mon, 18 Nov 2019 10:32:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=Bf+C7PC5; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id l17so361909wmh.0 for ; Mon, 18 Nov 2019 10:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h40UpoBSL4HkOq7Sjw/SXNRqMcLAqExeTrtJceWaatM=; b=Bf+C7PC5i4H5EbE/bjCKYgqss1MlEZpn5zU1AfdoXEnpPiv5p/zdLm1Wk1X0urRLpC 8n9dx2hLag4ldR2O/OMz+6nOjkARmb5Umo0K/TREeaYtYrl1+L5aqUkGhYcLVcVuQhAt 503DS+lwC5wra6WJJ7JI8G4fx5Zh97jC/A1rJb4F0HR0q5zjJxHGFHUPPvyVmSwLAjek fSHgRno4lY48WiRoh7RNtxFh1yqm0ejGZmS8pMhblFshL1vaGNUoVVRC5B7Yec2KqGDB i1RCtMeDvRBrhasRIWRXgxzQ2RxzhzxBp9xpJg/JVY4sJ3V6q5tGkV9MCejhkqfGvLJx T38Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h40UpoBSL4HkOq7Sjw/SXNRqMcLAqExeTrtJceWaatM=; b=qTCGGZ0XBstc9ZAiFWPx2c3+MatN2wgP4+z4ElsL9+grqSh+V432gatpLzf4zgdOgN zSLTtLWKY5xZ2+Pc5mCXwtq0db7vjsgop46mbh6gbzbWuuexmIeWW5f7oKek75Vk0v3o k4+M8Z0Ow1dkFDmY1NJYbUhe3sUaRvSBkNywJIdUri+GvL+DaPfA+6vFm9xnt8CLkj5Q WU32rv7Ns/1h0Zkl0t/8dxowSsvFdsDBgH+uhsYA6Y93IVFIi/J3BL9xTF4N8w4TNoWv 4zzqTzUPcfAmSIqezGnDPPR7VHH/jLhEccU+owI2NoKfPVTaQMgeTHWOdpDb1wV8hfQ7 es8A== X-Gm-Message-State: APjAAAWNDlyL8aw2r7XRokVzxHskmP7ZG2gbIBenOnleEZEkvsmHlj9b u7hZp3HrheYNfiWVCi5b65wkpg== X-Google-Smtp-Source: APXvYqxJUwoXFmS7bES82fYu4degC//Rqrsz3WVOZyRnPFGLasupuBvJuie+3dbDyUwT0FLbN/96+Q== X-Received: by 2002:a1c:6a09:: with SMTP id f9mr572421wmc.15.1574101972742; Mon, 18 Nov 2019 10:32:52 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.67.47]) by smtp.googlemail.com with ESMTPSA id t133sm691802wmb.1.2019.11.18.10.32.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 10:32:52 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection To: Leif Lindholm Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com References: <20191114160740.10072-1-pete@akeo.ie> <20191114160740.10072-2-pete@akeo.ie> <20191118175156.GX7323@bivouac.eciton.net> <99b30bf5-a9c6-62aa-f7e2-7db9c2bc9848@akeo.ie> <20191118180521.GY7323@bivouac.eciton.net> From: "Pete Batard" Message-ID: <3e51f090-9391-1c59-5a64-c2927011ccb1@akeo.ie> Date: Mon, 18 Nov 2019 18:32:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191118180521.GY7323@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.11.18 18:05, Leif Lindholm wrote: > On Mon, Nov 18, 2019 at 05:58:05PM +0000, Pete Batard wrote: >> On 2019.11.18 17:51, Leif Lindholm wrote: >>> On Thu, Nov 14, 2019 at 04:07:33PM +0000, Pete Batard wrote: >>>> From: Samer El-Haj-Mahmoud >>>> >>>> Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. >>>> >>>> This uses the board revision to return a numeric value representing >>>> the RPi family (1=RPi, 2=RPi2, 3=RPi3 and 4=RPi4). >>>> >>>> Knowing the Pi family will help us set the SD card routing when we >>>> introduce support for the Pi 4 and should also be easier to maintain >>>> than if using individual model detection. >>>> >>>> Also add a missing entry for the "Raspberry Pi Compute Module 3+" in >>>> RpiFirmwareGetModelName (). >>> >>> Can you drop the above line and include the below as 1/? in v2? >> >> Okay. >> >> Note that since you requested alphabetical for PCDs, I'm going to have an >> "Also" in 2/ (now 3/) since the existing PCDs in >> Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf are out of >> alphabetical order. > > Actually, I try to never request reordering of existing lines, so I > would be quite happy for you to skip the changes that would motivate > the use of the "also". > > I tend to apply a rule of trying to insert *new* (or moved) lines in a > way that will improve the existing order - or in messy cases at least > not make it worse. > > I have had it pointed out to me that this is maybe not entirely > obvious... Well, this is exactly what I would point out as an example of the strive for commit atomicity getting in the way of a more readable codebase as well as overall user experience (the users here being the developers who are dealing with the code). The reason I'm pointing this out is that, in the past, I have been dealing with projects that seemed to care more about keeping a squeaky clean commit history than they seemed to care about making the underlying code as good as it could possibly get, which resulted in increased pain for the developers having to contend with said codebase and ultimately end-users of the software produced from that codebase. Again, I would assert that there has to exist a middle ground between keeping a super-clean commit history and improving the source where it can indeed be improved at little cost, by not always defaulting to people having to devote extra time splitting patches. But I understand this is not my choice to make here. Thus I'll stay away from reordering that doesn't have to do with new PCDs being introduced. Regards, /Pete > > Regards, > > Leif > >> I sure hope you're not going to ask me to split this extra reordering into a >> separate commit... >> >> Regards, >> >> /Pete >> >>> >>> / >>> Leif >>> >>> From 59f01ff36ac7918e9ce166acbd3e963f638ab4b1 Mon Sep 17 00:00:00 2001 >>> From: Samer El-Haj-Mahmoud >>> Date: Mon, 18 Nov 2019 17:47:06 +0000 >>> Subject: [PATCH edk2-platforms 1/1] Platform/RPi: Add missing model name >>> >>> add a missing entry for the "Raspberry Pi Compute Module 3+" in >>> RpiFirmwareGetModelName (). >>> >>> Signed-off-by: Leif Lindholm >>> --- >>> Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >>> index 9b4aa068857c..dcb434fabefe 100644 >>> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >>> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c >>> @@ -1,5 +1,6 @@ >>> /** @file >>> * >>> + * Copyright (c) 2019, ARM Limited. All rights reserved. >>> * Copyright (c) 2017-2018, Andrei Warkentin >>> * Copyright (c) 2016, Linaro, Ltd. All rights reserved. >>> * >>> @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( >>> return "Raspberry Pi 3 Model B+"; >>> case 0x0E: >>> return "Raspberry Pi 3 Model A+"; >>> + case 0x10: >>> + return "Raspberry Pi Compute Module 3+"; >>> case 0x11: >>> return "Raspberry Pi 4 Model B"; >>> default: >>> >>