From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mx.groups.io with SMTP id smtpd.web11.18.1599844598016445694 for ; Fri, 11 Sep 2020 10:16:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=OK1HdczU; spf=pass (domain: nvidia.com, ip: 216.228.121.143, mailfrom: jbrasen@nvidia.com) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 11 Sep 2020 10:14:20 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 11 Sep 2020 10:16:37 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 11 Sep 2020 10:16:37 -0700 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 11 Sep 2020 17:16:34 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 11 Sep 2020 17:16:34 +0000 Received: from jbrasen-ux.nvidia.com (Not Verified[10.20.23.99]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Fri, 11 Sep 2020 10:16:33 -0700 From: "Jeff Brasen" To: CC: , , Jeff Brasen Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check Date: Fri, 11 Sep 2020 11:16:30 -0600 Message-ID: <3e6a774a62a4ef92fcdfb5e156e2abc4c440d35e.1599844505.git.jbrasen@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: jbrasen@nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1599844460; bh=P+6rU69sWIRm4QnXadF2i69ecpv1s7FauUkWyA3i3XQ=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:X-NVConfidentiality:Content-Transfer-Encoding: Content-Type; b=OK1HdczU4Bv/jqMrb2S+h6M8QeqK20+dbn8XAw0ZASzYe7KBSq5MW+4wgOydd7jX3 0Z9WgOGw3E7jeXNaK+57qc9kl2/bzX6YfmxmK32blXTbvTycU0cMtYwm3i3mIAj8Fz 7pc8SoSg1WljCIKpXiET83JLWk1qlxTDqwlKCSp75NBGHAqMelBmwkvTu17M5fvr28 WtLm1uDjmAfzEJiIFOLzSWWo+kO9+Jz5bP/i2yaoDM/OMncM/ZReFl7b0CeDEM5p9C JknRlC5oRYDFD1+hENtj6FfabmLVzwTiZOKID3EPV5n8t7+OhB8k+CQNGGddGKjBq+ gIfkyqSNUsn+g== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Add check for NULL HostAddress in AllocateBuffer as required by UEFI specification. Signed-off-by: Jeff Brasen --- .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverab= lePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDisco= verablePciDeviceIo.c index a40c1a9593..363c4a765b 100644 --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDe= viceIo.c +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDe= viceIo.c @@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer ( return EFI_UNSUPPORTED;=0D }=0D =0D + if (HostAddress =3D=3D NULL) {=0D + return EFI_INVALID_PARAMETER;=0D + }=0D +=0D if ((MemoryType !=3D EfiBootServicesData) &&=0D (MemoryType !=3D EfiRuntimeServicesData)) {=0D return EFI_INVALID_PARAMETER;=0D --=20 2.25.1