* [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
@ 2021-09-22 22:37 Rebecca Cran
2021-09-23 10:30 ` Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2021-09-22 22:37 UTC (permalink / raw)
To: devel, Ard Biesheuvel, Leif Lindholm, Graeme Gregory,
Radoslaw Biernacki
Cc: Rebecca Cran
Set the DSDT revision value to 2 by using the define from Acpi60.h
EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This
causes the AML interpreter to use full 64-bit integers and math.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
index e056d6cdb02e..1bf9fbb99e75 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
@@ -6,6 +6,7 @@
* SPDX-License-Identifier: BSD-2-Clause-Patent
**/
+#include <IndustryStandard/Acpi60.h>
#include <IndustryStandard/SbsaQemuAcpi.h>
#define LINK_DEVICE(Uid, LinkName, Irq) \
@@ -25,8 +26,9 @@
Address, Pin, Link, Zero \
}
-DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "LINARO", "SBSAQEMU",
- FixedPcdGet32 (PcdAcpiDefaultOemRevision)) {
+DefinitionBlock ("DsdtTable.aml", "DSDT",
+ EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION,
+ "LINARO", "SBSAQEMU", FixedPcdGet32 (PcdAcpiDefaultOemRevision)) {
Scope (_SB) {
// UART PL011
Device (COM0) {
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
2021-09-22 22:37 [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math Rebecca Cran
@ 2021-09-23 10:30 ` Leif Lindholm
2021-09-23 12:54 ` Rebecca Cran
0 siblings, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2021-09-23 10:30 UTC (permalink / raw)
To: Rebecca Cran; +Cc: devel, Ard Biesheuvel, Graeme Gregory, Radoslaw Biernacki
Not just an improvement, but an actual bugfix.
I would propose a subject line change though:
Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
->
Platform/Qemu: fix SbsaQemu DSDT format version
If you're OK with the change, I can fold that in.
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
On Wed, Sep 22, 2021 at 16:37:09 -0600, Rebecca Cran wrote:
> Set the DSDT revision value to 2 by using the define from Acpi60.h
> EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This
> causes the AML interpreter to use full 64-bit integers and math.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> index e056d6cdb02e..1bf9fbb99e75 100644
> --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
> @@ -6,6 +6,7 @@
> * SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> +#include <IndustryStandard/Acpi60.h>
> #include <IndustryStandard/SbsaQemuAcpi.h>
>
> #define LINK_DEVICE(Uid, LinkName, Irq) \
> @@ -25,8 +26,9 @@
> Address, Pin, Link, Zero \
> }
>
> -DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "LINARO", "SBSAQEMU",
> - FixedPcdGet32 (PcdAcpiDefaultOemRevision)) {
> +DefinitionBlock ("DsdtTable.aml", "DSDT",
> + EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION,
> + "LINARO", "SBSAQEMU", FixedPcdGet32 (PcdAcpiDefaultOemRevision)) {
> Scope (_SB) {
> // UART PL011
> Device (COM0) {
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
2021-09-23 10:30 ` Leif Lindholm
@ 2021-09-23 12:54 ` Rebecca Cran
2021-09-23 13:57 ` Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2021-09-23 12:54 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel, Ard Biesheuvel, Graeme Gregory, Radoslaw Biernacki
On 9/23/21 4:30 AM, Leif Lindholm wrote:
> Not just an improvement, but an actual bugfix.
>
> I would propose a subject line change though:
> Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
> ->
> Platform/Qemu: fix SbsaQemu DSDT format version
>
> If you're OK with the change, I can fold that in.
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Yes, please do.
--
Rebecca Cran
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
2021-09-23 12:54 ` Rebecca Cran
@ 2021-09-23 13:57 ` Leif Lindholm
0 siblings, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2021-09-23 13:57 UTC (permalink / raw)
To: Rebecca Cran; +Cc: devel, Ard Biesheuvel, Graeme Gregory, Radoslaw Biernacki
On Thu, Sep 23, 2021 at 06:54:24 -0600, Rebecca Cran wrote:
> On 9/23/21 4:30 AM, Leif Lindholm wrote:
> > Not just an improvement, but an actual bugfix.
> >
> > I would propose a subject line change though:
> > Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math
> > ->
> > Platform/Qemu: fix SbsaQemu DSDT format version
> >
> > If you're OK with the change, I can fold that in.
> > Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> Yes, please do.
Pushed as 8227e9e9f6a8.
Thanks!
/
Leif
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-23 13:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-22 22:37 [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math Rebecca Cran
2021-09-23 10:30 ` Leif Lindholm
2021-09-23 12:54 ` Rebecca Cran
2021-09-23 13:57 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox