From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org
Subject: Re: [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs
Date: Wed, 6 Dec 2017 15:14:10 +0100 [thread overview]
Message-ID: <3e8723e4-111b-2a31-8b07-2545434c3b9f@redhat.com> (raw)
In-Reply-To: <20171206113711.6040-1-ard.biesheuvel@linaro.org>
On 12/06/17 12:37, Ard Biesheuvel wrote:
> In order to allow the ArmVirtPkg platforms to be built using the
> NOOPT target, add it explicitly to the BUILD_TARGETS define.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> ArmVirtPkg/ArmVirtXen.dsc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index f09226671827..76a83b99a303 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf
>
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index cc2c5a50c925..7d9a9196d640 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf
>
> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
> index 9b3cc2bd5a10..175b56d10c8f 100644
> --- a/ArmVirtPkg/ArmVirtXen.dsc
> +++ b/ArmVirtPkg/ArmVirtXen.dsc
> @@ -25,7 +25,7 @@ [Defines]
> DSC_SPECIFICATION = 0x00010005
> OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH)
> SUPPORTED_ARCHITECTURES = AARCH64|ARM
> - BUILD_TARGETS = DEBUG|RELEASE
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2017-12-06 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 11:37 [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs Ard Biesheuvel
2017-12-06 14:14 ` Laszlo Ersek [this message]
2017-12-06 20:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e8723e4-111b-2a31-8b07-2545434c3b9f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox