From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 81DEE2217CE24 for ; Wed, 6 Dec 2017 06:09:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 480888048C; Wed, 6 Dec 2017 14:14:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-175.rdu2.redhat.com [10.10.120.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CBD77A3C5; Wed, 6 Dec 2017 14:14:11 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org References: <20171206113711.6040-1-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <3e8723e4-111b-2a31-8b07-2545434c3b9f@redhat.com> Date: Wed, 6 Dec 2017 15:14:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171206113711.6040-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 06 Dec 2017 14:14:12 +0000 (UTC) Subject: Re: [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 14:09:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/06/17 12:37, Ard Biesheuvel wrote: > In order to allow the ArmVirtPkg platforms to be built using the > NOOPT target, add it explicitly to the BUILD_TARGETS define. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemu.dsc | 2 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- > ArmVirtPkg/ArmVirtXen.dsc | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index f09226671827..76a83b99a303 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -25,7 +25,7 @@ [Defines] > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH) > SUPPORTED_ARCHITECTURES = AARCH64|ARM > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index cc2c5a50c925..7d9a9196d640 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -25,7 +25,7 @@ [Defines] > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH) > SUPPORTED_ARCHITECTURES = AARCH64|ARM > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf > > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 9b3cc2bd5a10..175b56d10c8f 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -25,7 +25,7 @@ [Defines] > DSC_SPECIFICATION = 0x00010005 > OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH) > SUPPORTED_ARCHITECTURES = AARCH64|ARM > - BUILD_TARGETS = DEBUG|RELEASE > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf > > Reviewed-by: Laszlo Ersek