Re: [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart

[Laszlo Ersek <lersek@redhat.com>]

Hi Star,

On 09/05/18 11:55, Zeng, Star wrote:
> I agree to commit this patch first. Reviewed-by: Star Zeng <star.zeng@intel.com> to this patch.
> 
> To further enhance with an abstracted function, how about like below?
> 
> BOOLEAN
> EhcIsDebugPortInUse (
> IN CONST USB2_HC_DEV *Ehc,
> IN UINT8             *PortNumber OPTIONAL
> )

do you want me to define the new EhcIsDebugPortInUse() function in
"Ehci.c", or in "EhciReg.c"?

"EhciReg.c" looks more appropriate to me:

- EhcIsHalt() is defined there,

- EhcIsSysError() is defined there,

- the EhcReadDbgRegister() function would become internal to
  "EhciReg.c", because all of the current call sites (in "Ehci.c") would
  be replaced by calls to EhcIsDebugPortInUse(). In turn this would
  allow us to remove the declaration of EhcReadDbgRegister(), from
  "EhciReg.h".

Thanks!
Laszlo