From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2684021A02937
 for <edk2-devel@lists.01.org>; Wed,  5 Sep 2018 05:18:17 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 68870401EF07;
 Wed,  5 Sep 2018 12:18:16 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-25.rdu2.redhat.com
 [10.10.121.25])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D520E2027EA0;
 Wed,  5 Sep 2018 12:18:15 +0000 (UTC)
To: "Zeng, Star" <star.zeng@intel.com>, edk2-devel-01 <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>
References: <20180831140330.26888-1-lersek@redhat.com>
 <0C09AFA07DD0434D9E2A0C6AEB0483103BBB4C09@shsmsx102.ccr.corp.intel.com>
 <e3ff0c9a-6e44-74d3-08dc-dc0f51516175@redhat.com>
 <0C09AFA07DD0434D9E2A0C6AEB0483103BBB4E60@shsmsx102.ccr.corp.intel.com>
 <9aa5a24b-44b4-fb14-cb68-35028edf0906@redhat.com>
 <0C09AFA07DD0434D9E2A0C6AEB0483103BBB55E8@shsmsx102.ccr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <3e8f82f6-5dbf-b187-e497-82a026587c2d@redhat.com>
Date: Wed, 5 Sep 2018 14:18:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBB55E8@shsmsx102.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.5]); Wed, 05 Sep 2018 12:18:16 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]);
 Wed, 05 Sep 2018 12:18:16 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH] MdeModulePkg/EhciDxe: fix host controller reset condition in BindingStart
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Sep 2018 12:18:17 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Star,

On 09/05/18 11:55, Zeng, Star wrote:
> I agree to commit this patch first. Reviewed-by: Star Zeng <star.zeng@intel.com> to this patch.
> 
> To further enhance with an abstracted function, how about like below?
> 
> BOOLEAN
> EhcIsDebugPortInUse (
> IN CONST USB2_HC_DEV *Ehc,
> IN UINT8             *PortNumber OPTIONAL
> )

do you want me to define the new EhcIsDebugPortInUse() function in
"Ehci.c", or in "EhciReg.c"?

"EhciReg.c" looks more appropriate to me:

- EhcIsHalt() is defined there,

- EhcIsSysError() is defined there,

- the EhcReadDbgRegister() function would become internal to
  "EhciReg.c", because all of the current call sites (in "Ehci.c") would
  be replaced by calls to EhcIsDebugPortInUse(). In turn this would
  allow us to remove the declaration of EhcReadDbgRegister(), from
  "EhciReg.h".

Thanks!
Laszlo