Hi Laszlo,

Sorry, I'm not check carefully, it is really **copied**, and we not think the ARM version is not good enough.

So, can I move this library to OvmfPkg so other ARCH use it easily?

Thanks,
Chao

在 2023/11/9 06:24, Laszlo Ersek 写道:

On 11/6/23 04:30, Chao Li wrote:

This library is provides boot mananger interfaces, and it is referenced
from ArmVirtPkg.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
Co-authored-by: Xianglai Li <lixianglai@loongson.cn>
Co-authored-by: Bibo Mao <maobibo@loongson.cn>
---
 .../PlatformBootManagerLib/PlatformBm.c       | 829 ++++++++++++++++++
 .../PlatformBootManagerLib/PlatformBm.h       | 112 +++
 .../PlatformBootManagerLib.inf                |  73 ++
 .../PlatformBootManagerLib/QemuKernel.c       |  81 ++
 4 files changed, 1095 insertions(+)
 create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBm.c
 create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBm.h
 create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
 create mode 100644 OvmfPkg/LoongArchVirt/Library/PlatformBootManagerLib/QemuKernel.c

I wish it were "referenced"; it's not referenced but *copied*.

Why is the library in ArmVirtPkg not good enough? What are the
differences? Etc.

I'm not even asking about the specifics here, but trying to show you how
you should please *present* this platform enablement for review.

Laszlo

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_