From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id CEDCB21B02822
 for <edk2-devel@lists.01.org>; Mon,  7 Jan 2019 11:17:34 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 37DAC3C58;
 Mon,  7 Jan 2019 19:17:34 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-126-62.rdu2.redhat.com
 [10.10.126.62])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 58BDC608DC;
 Mon,  7 Jan 2019 19:17:33 +0000 (UTC)
To: "Ni, Ray" <ray.ni@intel.com>, "Dong, Eric" <eric.dong@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
References: <20190107010555.23264-1-eric.dong@intel.com>
 <20190107010555.23264-3-eric.dong@intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5BFA53EB@SHSMSX103.ccr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <3ea78f2e-0e77-3ebc-81ac-84df978de197@redhat.com>
Date: Mon, 7 Jan 2019 20:17:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BFA53EB@SHSMSX103.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Mon, 07 Jan 2019 19:17:34 +0000 (UTC)
Subject: Re: [Patch 2/2] UefiCpuPkg/RegisterCpuFeaturesLib: Avoid AP calls PeiService.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 19:17:35 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/07/19 09:24, Ni, Ray wrote:
> 1.
> How about defining a union for MpService.
> typedef union {
>   EFI_MP_SERVICES_PROTOCOL  *Protocol;
>   EFI_PEI_MP_SERVICES_PPI         *Ppi;
> } MP_SERVICES;
> So a new field as below can be added here:
> 
> MP_SERVICES      MpService;
> 
> GetMpService() can be also changed to return MP_SERVICES;
> 
> 2. Please update the copyright year to 2019.

- I wasn't CC'd on the cover letter, and the patches themselves don't
include any version numbers, so it's hard to tell what version this is.

- Upon examining my list folder, in addition to my inbox, the cover
letter seems to be "[edk2] [Patch v2 0/2] Avoid AP calls PeiServices
table." -- at
<https://lists.01.org/pipermail/edk2-devel/2019-January/034675.html>.

That's incorrect; this is version 3 actually. V1 was at
<https://lists.01.org/pipermail/edk2-devel/2018-December/034262.html>,
and the actual v2 was at
<https://lists.01.org/pipermail/edk2-devel/2018-December/034440.html>.

- As I stated under v2, at
<https://lists.01.org/pipermail/edk2-devel/2018-December/034493.html>,
I'll defer to Ray on v3.

Thanks,
Laszlo