public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: Jeremy Linton <jeremy.linton@arm.com>, devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com,
	samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com
Subject: Re: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer
Date: Thu, 8 Apr 2021 10:48:12 +0100	[thread overview]
Message-ID: <3ebbaa5f-f321-d5fb-f99f-d167c0de47cc@akeo.ie> (raw)
In-Reply-To: <20210408055843.2883563-4-jeremy.linton@arm.com>

On 2021.04.08 06:58, Jeremy Linton wrote:
> Bridge devices should be marked as producers so that their
> children can consume the resources. In linux if this isn't
> true then the translation gets ignored and the DMA values
> are incorrect. This fixes DMA on all the devices that
> need a translation.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>   Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
>   Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> index d116f965e1..32cd5fc9f9 100644
> --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> @@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2)
>           // Only the first GB is available.
> 
>           // Bus 0xC0000000 -> CPU 0x00000000.
> 
>           //
> 
> -        QWordMemory (ResourceConsumer,
> 
> +        QWordMemory (ResourceProducer,
> 
>             ,
> 
>             MinFixed,
> 
>             MaxFixed,
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl
> index 179dd3ecdb..0fbc2a79ea 100644
> --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl
> @@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2)
>         }
> 
>   
> 
>         Name (_DMA, ResourceTemplate() {
> 
> -        QWordMemory (ResourceConsumer,
> 
> +        QWordMemory (ResourceProducer,
> 
>             ,
> 
>             MinFixed,
> 
>             MaxFixed,
> 

Reviewed-by: Pete Batard <pete@akeo.ie>

  reply	other threads:[~2021-04-08  9:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  5:58 [PATCH 0/3] SD+USB perf/DMA fixes Jeremy Linton
2021-04-08  5:58 ` [PATCH 1/3] Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Jeremy Linton
2021-04-08  9:48   ` Pete Batard
2021-04-08 14:17     ` Andrei Warkentin
2021-05-10 16:41       ` Samer El-Haj-Mahmoud
2021-05-10 16:41     ` Samer El-Haj-Mahmoud
2021-05-10 16:41   ` Samer El-Haj-Mahmoud
2021-04-08  5:58 ` [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Jeremy Linton
2021-04-08  9:48   ` Pete Batard
2021-05-10 16:41     ` Samer El-Haj-Mahmoud
2021-04-08 14:17   ` Andrei Warkentin
2021-05-10 16:42     ` Samer El-Haj-Mahmoud
2021-05-10 16:41   ` Samer El-Haj-Mahmoud
2021-04-08  5:58 ` [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Jeremy Linton
2021-04-08  9:48   ` Pete Batard [this message]
2021-05-10 16:43     ` Samer El-Haj-Mahmoud
2021-04-08 14:23   ` Andrei Warkentin
2021-04-13 16:44     ` Samer El-Haj-Mahmoud
     [not found]     ` <167578A6C978A75F.9301@groups.io>
2021-04-29 14:02       ` [edk2-devel] " Samer El-Haj-Mahmoud
     [not found]       ` <167A591C4A42BD1B.6294@groups.io>
2021-04-30 18:05         ` Samer El-Haj-Mahmoud
2021-05-10 16:42           ` Samer El-Haj-Mahmoud
2021-05-10 16:43   ` Samer El-Haj-Mahmoud
2021-04-08 14:24 ` [PATCH 0/3] SD+USB perf/DMA fixes Andrei Warkentin
2021-04-30 18:28   ` Samer El-Haj-Mahmoud
     [not found]   ` <167AB62D787B8F90.7155@groups.io>
2021-05-10 16:40     ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-04-30 20:30 ` Andrei Warkentin
2021-05-10 16:39   ` [edk2-devel] " Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ebbaa5f-f321-d5fb-f99f-d167c0de47cc@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox