From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web11.5829.1617875295260707528 for ; Thu, 08 Apr 2021 02:48:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=h+JZ9K32; spf=pass (domain: akeo.ie, ip: 209.85.221.49, mailfrom: pete@akeo.ie) Received: by mail-wr1-f49.google.com with SMTP id e12so1403518wro.11 for ; Thu, 08 Apr 2021 02:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GsISgUwsrYe2+fkHLRtaCIQykc8btLCXPJTSxC8tR+o=; b=h+JZ9K32TU+n1n34sSuR4rgq9D56JNxgPa+lk+RdOiDAZYiAX0PnISOtY071MTsxQ8 KK5kOYjw9+mT2BO6HsVKZxqkJ9iW7UnqgBRnpJ/khvaqtfZvNYgrLLl9BZI2Zx/MQRSK xZnBx3lsuYrA05XQlXm4TujM+MvLfGer5yuGlDj0JbUZrysX/uALo6ARGCihD1Aq90u/ ZaurwtVANG5fgNzaKCe9gcXS6PQjkXF8KhP7OYb2WsP9gnXua4zbKArP4eemdvpOHvU+ Jdsx6VwY27hlpOY26DDhmi8wiC5te47f5WTl+3MGj4UFaE8tR7D2r84daqZkiTn//4t5 02NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GsISgUwsrYe2+fkHLRtaCIQykc8btLCXPJTSxC8tR+o=; b=FewtRRd2mL7XCQ5ZYp1/K+Qhnq/xyp6sraBX7j/6CX3tSi5j8oKw4Bq6y/h5l5HcBo EtZbaU9we3kzXGf2jaDmGYo9/Zio41fQamkDXcOOQdHM8mJpJrbZolvbapfgG1cBCCHX EMBgajd8szssYNDEYEbU2wn+sbuUNlpnWSKD65Of1vpWr1J+I+k9OBZBA/ZAGm6L4REo IR3Lxaq5Do4pyu3t1gAwa3t8NaPfDG2OExBZSmImeQ7koZyFlvPHCfLQnvKxFHEipH0r S5N4r5YjtkPds4jcnpQUMRFlL12PIKOpylEzAwAt4WWTkEE/hxebUhmzkYmqjCm0C0Sh 0ziw== X-Gm-Message-State: AOAM530cPDQgryS5zLm/VGIgm8wNslQ3+AqZixRUxVh5ryKPm0FiR43s B9fRXaG6AoD7WXK0TJDUTgLGzg== X-Google-Smtp-Source: ABdhPJzGFmPrH88lzJ/z7q/5JeDjHD6SPT0XFE3mDYJscKwKyjURhSDbl9EFSLvHqo1gx9WFo9/Tbw== X-Received: by 2002:adf:e604:: with SMTP id p4mr10286004wrm.53.1617875293864; Thu, 08 Apr 2021 02:48:13 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.65.130]) by smtp.googlemail.com with ESMTPSA id w7sm20684808wru.74.2021.04.08.02.48.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 02:48:13 -0700 (PDT) Subject: Re: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer To: Jeremy Linton , devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com References: <20210408055843.2883563-1-jeremy.linton@arm.com> <20210408055843.2883563-4-jeremy.linton@arm.com> From: "Pete Batard" Message-ID: <3ebbaa5f-f321-d5fb-f99f-d167c0de47cc@akeo.ie> Date: Thu, 8 Apr 2021 10:48:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210408055843.2883563-4-jeremy.linton@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021.04.08 06:58, Jeremy Linton wrote: > Bridge devices should be marked as producers so that their > children can consume the resources. In linux if this isn't > true then the translation gets ignored and the DMA values > are incorrect. This fixes DMA on all the devices that > need a translation. > > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- > Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl > index d116f965e1..32cd5fc9f9 100644 > --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl > +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl > @@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2) > // Only the first GB is available. > > // Bus 0xC0000000 -> CPU 0x00000000. > > // > > - QWordMemory (ResourceConsumer, > > + QWordMemory (ResourceProducer, > > , > > MinFixed, > > MaxFixed, > > diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryPi/AcpiTables/Emmc.asl > index 179dd3ecdb..0fbc2a79ea 100644 > --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl > +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl > @@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC", 2) > } > > > > Name (_DMA, ResourceTemplate() { > > - QWordMemory (ResourceConsumer, > > + QWordMemory (ResourceProducer, > > , > > MinFixed, > > MaxFixed, > Reviewed-by: Pete Batard