Re: [edk2-devel] [PATCH v2] OvmfPkg: Make SOURCE_DEBUG_ENABLE actually need to be set to TRUE

["Laszlo Ersek" <lersek@redhat.com>]

On 10/21/19 22:13, Laszlo Ersek wrote:
> From: Peter Jones <pjones@redhat.com>
> 
> Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
> tests check if it's defined or not.  Additionally, in UefiPayloadPkg as
> well as some other trees, we define it as FALSE in the .dsc file.
> 
> This patch changes all of the Ovmf platforms to explicitly define it as
> FALSE by default, and changes all of the checks to test if the value is
> TRUE.
> 
> Signed-off-by: Peter Jones <pjones@redhat.com>
> Message-Id: <20190920184507.909884-1-pjones@redhat.com>
> [lersek@redhat.com: drop Contributed-under line, per TianoCore BZ#1373]
> [lersek@redhat.com: replace "!= TRUE" with more idiomatic "== FALSE"]
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Peter Jones <pjones@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v2:
>     
>     - repo:   https://github.com/lersek/edk2.git
>       branch: src_dbg_true_v2
>     
>     - repost the patch in Peter's stead, with the updates requested at
>       <http://mid.mail-archive.com/9c6d70b5-fcd6-373f-973f-044d1338e47b@redhat.com>
>     
>     - per discussion with the other stewards, it's OK to explicitly resubmit
>       the patch (noting the original authorship) with the Contributed-under
>       line removed
> 
>  OvmfPkg/OvmfPkgIa32.dsc    | 17 +++++++++--------
>  OvmfPkg/OvmfPkgIa32X64.dsc | 19 ++++++++++---------
>  OvmfPkg/OvmfPkgX64.dsc     | 19 ++++++++++---------
>  OvmfPkg/OvmfXen.dsc        | 17 +++++++++--------
>  OvmfPkg/OvmfPkgIa32.fdf    |  2 +-
>  OvmfPkg/OvmfPkgIa32X64.fdf |  2 +-
>  OvmfPkg/OvmfPkgX64.fdf     |  2 +-
>  OvmfPkg/OvmfXen.fdf        |  2 +-
>  8 files changed, 42 insertions(+), 38 deletions(-)

Commit 46bb81200742.

Thanks all,
Laszlo