From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.1353.1571769157665975931 for ; Tue, 22 Oct 2019 11:32:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VZp616yV; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571769156; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dzfQz6op1lCDWYK/+4sgmPts5p0whADhpFuEA1IxrbQ=; b=VZp616yV87AoIPMfkivxhLUOfp45oezzYi5bKy3eUVI07JZotdkv7tCAENhQkGdcC7ngWh HAFnGTi+sCtkyInIDQ1jnLzpKUhx6p+sf/prx1/sV15RPW3idUcv5s7PW28L9dyg8gT2Jt i1FMmNd1euWogXl+MoP1Di/2mnxlacA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-NKXK23JQP9W7nGeB813gZA-1; Tue, 22 Oct 2019 14:32:33 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92939476; Tue, 22 Oct 2019 18:32:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F34A19C69; Tue, 22 Oct 2019 18:32:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Make SOURCE_DEBUG_ENABLE actually need to be set to TRUE From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Andrew Fish , Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Leif Lindholm , Michael Kinney , Peter Jones Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20191021201320.24413-1-lersek@redhat.com> Message-ID: <3ed8130c-1da1-143c-b12e-6faf5052a9c7@redhat.com> Date: Tue, 22 Oct 2019 20:32:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191021201320.24413-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: NKXK23JQP9W7nGeB813gZA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/21/19 22:13, Laszlo Ersek wrote: > From: Peter Jones >=20 > Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some > tests check if it's defined or not. Additionally, in UefiPayloadPkg as > well as some other trees, we define it as FALSE in the .dsc file. >=20 > This patch changes all of the Ovmf platforms to explicitly define it as > FALSE by default, and changes all of the checks to test if the value is > TRUE. >=20 > Signed-off-by: Peter Jones > Message-Id: <20190920184507.909884-1-pjones@redhat.com> > [lersek@redhat.com: drop Contributed-under line, per TianoCore BZ#1373] > [lersek@redhat.com: replace "!=3D TRUE" with more idiomatic "=3D=3D FALSE= "] > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Michael Kinney > Cc: Peter Jones > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > v2: > =20 > - repo: https://github.com/lersek/edk2.git > branch: src_dbg_true_v2 > =20 > - repost the patch in Peter's stead, with the updates requested at > > =20 > - per discussion with the other stewards, it's OK to explicitly resub= mit > the patch (noting the original authorship) with the Contributed-und= er > line removed >=20 > OvmfPkg/OvmfPkgIa32.dsc | 17 +++++++++-------- > OvmfPkg/OvmfPkgIa32X64.dsc | 19 ++++++++++--------- > OvmfPkg/OvmfPkgX64.dsc | 19 ++++++++++--------- > OvmfPkg/OvmfXen.dsc | 17 +++++++++-------- > OvmfPkg/OvmfPkgIa32.fdf | 2 +- > OvmfPkg/OvmfPkgIa32X64.fdf | 2 +- > OvmfPkg/OvmfPkgX64.fdf | 2 +- > OvmfPkg/OvmfXen.fdf | 2 +- > 8 files changed, 42 insertions(+), 38 deletions(-) Commit 46bb81200742. Thanks all, Laszlo