From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.23424.1629723436400978618 for ; Mon, 23 Aug 2021 05:57:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fI2JDFlS; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629723435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/XQsp+jXFn0slmW6IW+Wc54q7W5lTKBHyK6/NChllE=; b=fI2JDFlSJ+qlw+yJagWl9wCleeJPEhwbNJFVsiDxV5UC5bknPXyXkXAqsB8bgWAWSo0l4j X/LXUSUERCORAKXKmoi5nAYyaieAkCANF+7s5sYaDE9Stg9K5Y4HByclFcCL0V465n4ezb OIHLdRftxcc4RA2DAsJASvHdlWzjSMk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-NpmAvk3qNVi2tg84FPzWjw-1; Mon, 23 Aug 2021 08:57:12 -0400 X-MC-Unique: NpmAvk3qNVi2tg84FPzWjw-1 Received: by mail-wm1-f69.google.com with SMTP id a201-20020a1c7fd2000000b002e748bf0544so1877934wmd.2 for ; Mon, 23 Aug 2021 05:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G/XQsp+jXFn0slmW6IW+Wc54q7W5lTKBHyK6/NChllE=; b=OKQm1878Ojb3JID08njJKJxhyKVcFKfIBmV5nZ8uXNGxoaQW01l5xEQb5+CprD5OG9 NzcPukQ2cxF/2xq6dxOQ3dkklHo6lCJR4aQ7/kO5kb0YX0L8gPXg4wYFuMeE7lnexbX4 OOWedQgZpWxEJoml9UYKYVHFD7ueYS5Bll/5IWH0z2zQjE+YCJbGaZW+zdS9v7PJTCep mU6oB976koaOIemVkUtVC5+s4IlkbLouDUeO0qUd66iF3xXp8y1wEXE24vQu5CIBQmYZ EO4Sq+Su4wWP7cuNbTac1BcDa16x6E2kDIVX6P2jzzZRd/sSkzu6sPaAbpKstJ+JhrP8 STnQ== X-Gm-Message-State: AOAM5302Ho4c4CY31LsRTBGOBymxnRrt+dtcVEZ24IhY3GPcMQPWzgmL cX9KUpxg11rtRp2wFc6EWsw3gNAoU4ClkyINOAYw4sZMWq3+2SsJs906NENrhz1IsG1Ga1n9SxS O9aXKkPYD8Gtizw== X-Received: by 2002:a05:600c:4e8b:: with SMTP id f11mr9920246wmq.165.1629723431143; Mon, 23 Aug 2021 05:57:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1MW9UM0s/i/Ep/LSwyhY4R65AfFsp0/qOimThZGQODs9oqKwJGNocFeMF783aUlRYwWbkDQ== X-Received: by 2002:a05:600c:4e8b:: with SMTP id f11mr9920227wmq.165.1629723430976; Mon, 23 Aug 2021 05:57:10 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id r8sm15014873wrj.11.2021.08.23.05.57.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Aug 2021 05:57:10 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To: devel@edk2.groups.io, gary.lin@hpe.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Jim Fehlig , Joey Li References: <20210823070925.10095-1-gary.lin@hpe.com> <20210823070925.10095-3-gary.lin@hpe.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <3edd7ab8-9669-ae03-89bb-724fb51d3e98@redhat.com> Date: Mon, 23 Aug 2021 14:57:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210823070925.10095-3-gary.lin@hpe.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/23/21 9:09 AM, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > To avoid the potential inconsistency between PcdAcpiS3Enable and > QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect > S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. > > v3: > - Add the bugzilla link > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > cc: Jordan Justen > Cc: Jim Fehlig > Cc: Joey Li > Signed-off-by: Gary Lin > --- > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > 2 files changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daude